Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWED-2268 vscroll via dataset not class + glow #904

Merged

Conversation

goldenraphti
Copy link
Collaborator

Description

  • add scroll-blocking via data-attribute, so it does not interfere with component scripts such as topbar blocking body vscroll
  • add glow-effect to the expand/reduce button, to make it "POP" 🎆

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have updated the CHANGELOG document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Review instructions

Review instructions

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #904 (3a1782f) into develop (25dce2f) will decrease coverage by 0.02%.
Report is 1 commits behind head on develop.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #904      +/-   ##
===========================================
- Coverage    72.67%   72.65%   -0.02%     
===========================================
  Files          211      211              
  Lines         4497     4498       +1     
  Branches      1258     1257       -1     
===========================================
  Hits          3268     3268              
- Misses        1092     1093       +1     
  Partials       137      137              
Files Changed Coverage Δ
src/App/docutils/ComponentPreview/index.js 36.60% <0.00%> (-0.17%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f53154c...3a1782f. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Size Change: +1.07 kB (0%)

Total Size: 1.1 MB

Filename Size Change
dist/designguide/styles/documentation-payex.css 8.57 kB +263 B (+3%)
dist/designguide/styles/documentation-swedbankpay.css 7.67 kB +261 B (+4%)
dist/styles/documentation-payex.css 8.57 kB +263 B (+3%)
dist/styles/documentation-swedbankpay.css 7.67 kB +261 B (+4%)
ℹ️ View Unchanged
Filename Size Change
dist/designguide/scripts/dg-dashboard.js 72.9 kB 0 B
dist/designguide/scripts/dg.js 24.5 kB 0 B
dist/designguide/styles/payex.css 41.1 kB 0 B
dist/designguide/styles/swedbankpay.css 39.1 kB 0 B
dist/scripts/9438.js 71.8 kB 0 B
dist/scripts/dg-dashboard.js 72.9 kB 0 B
dist/scripts/dg.js 24.5 kB 0 B
dist/scripts/payex.js 322 kB +11 B (0%)
dist/scripts/swedbankpay.js 322 kB +11 B (0%)
dist/styles/payex.css 41.1 kB 0 B
dist/styles/swedbankpay.css 39.1 kB 0 B

compressed-size-action

@goldenraphti goldenraphti merged commit 3a1782f into develop Sep 25, 2023
0 of 2 checks passed
@github-actions github-actions bot deleted the feature/SWED-2268-expandable_component_preview branch September 25, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant