Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWED-2288 bank id button secondary #906

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

goldenraphti
Copy link
Collaborator

Description

https://payexjira.atlassian.net/browse/SWED-2288

refactor button bank-id styles to offer possibility to use bank-id button both for type primary OR secondary. Previously only type primary was possible. Merchant portal needs to use it as secondary.

Documentation gets updated. Component preview offer options for bank-id tab to select btn type primary OR secondary.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have updated the CHANGELOG document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Review instructions

Review instructions

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #906 (14c5b78) into develop (3a1782f) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #906   +/-   ##
========================================
  Coverage    72.65%   72.65%           
========================================
  Files          211      211           
  Lines         4498     4498           
  Branches      1257     1257           
========================================
  Hits          3268     3268           
  Misses        1093     1093           
  Partials       137      137           
Files Coverage Δ
...nentsDocumentation/components/Buttons/constants.js 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a1782f...14c5b78. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Size Change: +240 B (0%)

Total Size: 1.1 MB

ℹ️ View Unchanged
Filename Size Change
dist/designguide/scripts/dg-dashboard.js 72.9 kB 0 B
dist/designguide/scripts/dg.js 24.5 kB 0 B
dist/designguide/styles/documentation-payex.css 8.57 kB 0 B
dist/designguide/styles/documentation-swedbankpay.css 7.67 kB 0 B
dist/designguide/styles/payex.css 41.2 kB +49 B (0%)
dist/designguide/styles/swedbankpay.css 39.2 kB +71 B (0%)
dist/scripts/9438.js 71.8 kB 0 B
dist/scripts/dg-dashboard.js 72.9 kB 0 B
dist/scripts/dg.js 24.5 kB 0 B
dist/scripts/payex.js 322 kB 0 B
dist/scripts/swedbankpay.js 322 kB 0 B
dist/styles/documentation-payex.css 8.57 kB 0 B
dist/styles/documentation-swedbankpay.css 7.67 kB 0 B
dist/styles/payex.css 41.2 kB +49 B (0%)
dist/styles/swedbankpay.css 39.2 kB +71 B (0%)

compressed-size-action

@MariusSjo
Copy link

👋

@goldenraphti goldenraphti merged commit 53156c0 into develop Oct 11, 2023
8 checks passed
@github-actions github-actions bot deleted the feature/SWED-2288-bank_id_button_secondary branch October 11, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants