SWED-2276 import & adapt for atlas icons #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #927 +/- ##
===========================================
+ Coverage 72.30% 72.41% +0.10%
===========================================
Files 212 212
Lines 4586 4604 +18
Branches 1306 1309 +3
===========================================
+ Hits 3316 3334 +18
Misses 1126 1126
Partials 144 144
Continue to review full report in Codecov by Sentry.
|
|
Size Change: +10.9 kB (+1%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
- update iconography documentation
This was referenced Jan 19, 2024
10 tasks
src/less/components/payex/toast.less
Outdated
Comment on lines
16
to
17
| // TODO: is it actually needed ? why ? is it to make sure it's material icons normal and NOT material icons OUTLINED ? | ||
| // maybe we can remove it |
There was a problem hiding this comment.
I cannot see any reason for this rule, I suppose it is meant to do something with the close icon. but as it is implemented I cant see it fixing anything. I vote remove.
src/less/components/toast.less
Outdated
| @@ -98,7 +96,7 @@ | |||
| } | |||
| } | |||
|
|
|||
| .material-icons { | |||
| i { | |||
There was a problem hiding this comment.
Probably a bit too generic since it is okay to pass html as content to the toast
stepandersen
previously approved these changes
Jan 29, 2024
|
self-approved PR-merge after fixing comments from Stephan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://payexjira.atlassian.net/browse/SWED-2276
1st phase migrating icons from Google Material Icons to a combo Atlas icons & Swedbankpay custom icons
Material icons are still silently supported
but new icons are also supported
documentation have been complemented and updated (but not entirely rewritten, for lack of time, but it would be useful to do it at some point)
components are getting updated little by little.
They are all supporting new icons, but not all component code snippets have been updated
The DS website icons have not all been migrated yet
a 2nd iteration is needed to complete all of it.
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Review instructions
Review instructions