Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWED-2380 migrate icons DS website #929

Merged
merged 6 commits into from
Feb 8, 2024

Conversation

goldenraphti
Copy link
Collaborator

@goldenraphti goldenraphti commented Jan 8, 2024

Description

Part of the 2nd iteration of the icons migration.
This relates to Jira ticket SWED-2380

  • Migrate the DG documentation website icons from material-icons to the combination Atlas + our custom Swepay-icons.
  • This should be be altering the package in any way. It should therefore be a fairly safe PR.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have updated the CHANGELOG document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Review instructions

Review instructions

Copy link

github-actions bot commented Jan 8, 2024

Size Change: -4 B (0%)

Total Size: 1.13 MB

ℹ️ View Unchanged
Filename Size Change
dist/designguide/scripts/dg-dashboard.js 72.9 kB 0 B
dist/designguide/scripts/dg.js 24.7 kB 0 B
dist/designguide/styles/documentation-payex.css 9.96 kB 0 B
dist/designguide/styles/documentation-swedbankpay.css 9.02 kB 0 B
dist/designguide/styles/payex.css 47.3 kB 0 B
dist/designguide/styles/swedbankpay.css 44.9 kB 0 B
dist/scripts/712.js 71.8 kB 0 B
dist/scripts/dg-dashboard.js 72.9 kB 0 B
dist/scripts/dg.js 24.7 kB 0 B
dist/scripts/payex.js 322 kB -1 B (0%)
dist/scripts/swedbankpay.js 323 kB -3 B (0%)
dist/styles/documentation-payex.css 9.96 kB 0 B
dist/styles/documentation-swedbankpay.css 9.02 kB 0 B
dist/styles/payex.css 47.3 kB 0 B
dist/styles/swedbankpay.css 44.9 kB 0 B

compressed-size-action

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (88d6320) 72.41% compared to head (0446dfd) 72.43%.
Report is 8 commits behind head on develop.

❗ Current head 0446dfd differs from pull request most recent head 1f17fe4. Consider uploading reports for the commit 1f17fe4 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #929      +/-   ##
===========================================
+ Coverage    72.41%   72.43%   +0.01%     
===========================================
  Files          212      212              
  Lines         4604     4600       -4     
  Branches      1309     1306       -3     
===========================================
- Hits          3334     3332       -2     
+ Misses        1126     1124       -2     
  Partials       144      144              
Files Coverage Δ
...c/App/GetStarted/get-started/ForDesigners/index.js 45.45% <ø> (ø)
.../App/GetStarted/get-started/ForDevelopers/index.js 86.11% <ø> (ø)
...p/GetStarted/get-started/Introduction/constants.js 100.00% <ø> (ø)
...c/App/GetStarted/get-started/Introduction/index.js 69.23% <ø> (ø)
src/App/Home/index.js 17.39% <ø> (ø)
src/App/Identity/identity/Accessibility/index.js 84.21% <ø> (ø)
src/App/Identity/identity/Color/index.js 61.01% <ø> (ø)
src/App/Identity/identity/Copywriting/index.js 75.00% <ø> (ø)
src/App/Identity/identity/Grid/index.js 77.77% <ø> (ø)
src/App/Identity/identity/Iconography/index.js 100.00% <ø> (ø)
... and 19 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 146a01e...1f17fe4. Read the comment docs.

@goldenraphti goldenraphti marked this pull request as ready for review February 7, 2024 19:22
@goldenraphti goldenraphti merged commit 28aa610 into develop Feb 8, 2024
7 checks passed
@github-actions github-actions bot deleted the feature/SWED-2380-migrate_icons_DS_website branch February 8, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant