Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWED-2390 fix style tooltips position bug #932

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

goldenraphti
Copy link
Collaborator

  • a bug was introduced in 10.7.0 when we refactored the tooltips.less style files
  • the tooltip was positioned not corresponding to its parent element anymore
  • this was due to the position: relative removed from the parent .tooltip element during the refactor
  • this PR is reverting it

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have updated the CHANGELOG document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Review instructions

Review instructions

Copy link

github-actions bot commented Jan 10, 2024

Size Change: +102 B (0%)

Total Size: 1.12 MB

ℹ️ View Unchanged
Filename Size Change
dist/designguide/scripts/dg-dashboard.js 72.9 kB 0 B
dist/designguide/scripts/dg.js 24.7 kB 0 B
dist/designguide/styles/documentation-payex.css 9.9 kB 0 B
dist/designguide/styles/documentation-swedbankpay.css 8.98 kB 0 B
dist/designguide/styles/payex.css 44.4 kB +28 B (0%)
dist/designguide/styles/swedbankpay.css 42.3 kB +23 B (0%)
dist/scripts/9438.js 71.8 kB 0 B
dist/scripts/dg-dashboard.js 72.9 kB 0 B
dist/scripts/dg.js 24.7 kB 0 B
dist/scripts/payex.js 322 kB 0 B
dist/scripts/swedbankpay.js 322 kB 0 B
dist/styles/documentation-payex.css 9.9 kB 0 B
dist/styles/documentation-swedbankpay.css 8.98 kB 0 B
dist/styles/payex.css 44.4 kB +28 B (0%)
dist/styles/swedbankpay.css 42.3 kB +23 B (0%)

compressed-size-action

@goldenraphti goldenraphti merged commit 1f5bce7 into develop Jan 23, 2024
8 checks passed
@github-actions github-actions bot deleted the feature/SWED-2390-bugfix_tooltip branch January 23, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant