SWED-2505 Fixed issue where dropdown could not be initialized with ID #996
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The feature that was added where you could init a dropdown with an ID did not work.
The change I made changed querySelectorAll to findById and querySelector, and because these only return a single element, it broke these conditionals:
It also broke a forEach loop, but we returned null before we even got there.
Motivation and Context
How Has This Been Tested?
I created two unit tests to test the issue, which basically just renders a dropdown component and makes sure it doesn't log any errors when initialized with ID, and also that it does log error when initialized with an ID that doesn't exist.
Screenshots (if appropriate):
Types of changes
Checklist:
Review instructions
Review instructions