feat!: re-work user secrets #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leafty
force-pushed
the
leafty/session-secrets-5
branch
from
28a47c8 to
07a5ced
Compare
leafty
force-pushed
the
leafty/session-secrets-6
branch
from
f59b37a to
97f191d
Compare
leafty
force-pushed
the
leafty/session-secrets-5
branch
from
07a5ced to
3f25446
Compare
leafty
force-pushed
the
leafty/session-secrets-6
branch
from
f01c85c to
4f61bdc
Compare
leafty
force-pushed
the
leafty/session-secrets-5
branch
from
bfc1946 to
8b17e2a
Compare
leafty
force-pushed
the
leafty/session-secrets-6
branch
5 times, most recently
from
907cdea to
123d7a9
Compare
leafty
force-pushed
the
leafty/session-secrets-5
branch
from
8b17e2a to
3be57a8
Compare
leafty
force-pushed
the
leafty/session-secrets-6
branch
from
97ce3b8 to
841bc01
Compare
leafty
force-pushed
the
leafty/session-secrets-5
branch
from
3be57a8 to
9c7479b
Compare
leafty
force-pushed
the
leafty/session-secrets-6
branch
from
841bc01 to
4ef9480
Compare
olevski
requested changes
Dec 5, 2024
Base automatically changed from
leafty/session-secrets-5
to
build/session-secrets
December 5, 2024 09:30
leafty
force-pushed
the
leafty/session-secrets-6
branch
from
76e6bbd to
7035b09
Compare
olevski
approved these changes
Dec 6, 2024
leafty
added a commit
that referenced
this pull request
Dec 6, 2024
Re-work user secrets to make them more usable in Renku 2.0. Changes: * Change the `name` field to be `default_filename`. This field is only meaningful in the context of Renku 1.0. * Add a new `name` field (which does not have constraints) to let users name their secrets, e.g. "AWS Secret Key ID for Project XYZ". * User secret objects now include back references to Session secret slots and Data connectors -> `session_secret_slot_ids` and `data_connector_ids` fields returned from the API. * The `UserSecretsRepo` class has been split into `LowLevelUserSecretsRepo` and `UserSecretsRepo`. `LowLevelUserSecretsRepo` is used internally, e.g. for key rotation and `UserSecretsRepo` is used for the `UserSecretsBP` blueprint.
leafty
added a commit
that referenced
this pull request
Dec 9, 2024
Re-work user secrets to make them more usable in Renku 2.0. Changes: * Change the `name` field to be `default_filename`. This field is only meaningful in the context of Renku 1.0. * Add a new `name` field (which does not have constraints) to let users name their secrets, e.g. "AWS Secret Key ID for Project XYZ". * User secret objects now include back references to Session secret slots and Data connectors -> `session_secret_slot_ids` and `data_connector_ids` fields returned from the API. * The `UserSecretsRepo` class has been split into `LowLevelUserSecretsRepo` and `UserSecretsRepo`. `LowLevelUserSecretsRepo` is used internally, e.g. for key rotation and `UserSecretsRepo` is used for the `UserSecretsBP` blueprint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #509.
Re-work user secrets to make them more usable in Renku 2.0.
Changes:
namefield to bedefault_filename. This field is only meaningful in the context of Renku 1.0.namefield (which does not have constraints) to let users name their secrets, e.g. "AWS Secret Key ID for Project XYZ".session_secret_slot_idsanddata_connector_idsfields returned from the API.UserSecretsRepoclass has been split intoLowLevelUserSecretsRepoandUserSecretsRepo.LowLevelUserSecretsRepois used internally, e.g. for key rotation andUserSecretsRepois used for theUserSecretsBPblueprint.The database migration has been tested here -> SwissDataScienceCenter/renku#3845.