Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow project and data connector slugs to be changed #554

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

feat: allow project and data connector slugs to be changed #554

wants to merge 8 commits into from

Conversation

leafty
Copy link
Member

@leafty leafty commented Nov 29, 2024

WIP

Closes #544.

@coveralls
Copy link

coveralls commented Nov 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12138281743

Details

  • 48 of 50 (96.0%) changed or added relevant lines in 5 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.03%) to 85.897%
Changes Missing Coverage Covered Lines Changed/Added Lines %
components/renku_data_services/data_connectors/db.py 21 22 95.45%
components/renku_data_services/project/db.py 24 25 96.0%
Files with Coverage Reduction New Missed Lines %
components/renku_data_services/crc/models.py 1 85.35%
components/renku_data_services/crc/blueprints.py 3 93.38%
Totals Coverage Status
Change from base Build 12121772915: 0.03%
Covered Lines: 14538
Relevant Lines: 16925
💛 - Coveralls

@leafty leafty changed the title feat: allow the project's slug to be updated feat: allow project and data connector slugs to be changed Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow project and data_connector slugs to be changed
2 participants
@leafty @coveralls