Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set up concurrency limit for tests #560

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Conversation

Panaetius
Copy link
Member

this PR sets concurrency for the main tests, so old runs get properly cancelled if there's a new push.

I also changes it from group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} to group: ${{ github.workflow }}-${{ github.ref || github.run_id }}. The former is I think just copied from a stack overflow answer, but using github.ref makes more sense, as github.ref is already refs/pull/<pr_number>/merge, so unique per PR. run_id is used as a safety fallback for things that aren't PRs where we don't want concurrency.

@Panaetius Panaetius requested a review from a team as a code owner December 2, 2024 09:19
@coveralls
Copy link

coveralls commented Dec 2, 2024

Pull Request Test Coverage Report for Build 12121522276

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.006%) to 85.862%

Files with Coverage Reduction New Missed Lines %
components/renku_data_services/crc/blueprints.py 1 93.06%
Totals Coverage Status
Change from base Build 12121462595: 0.006%
Covered Lines: 14496
Relevant Lines: 16883

💛 - Coveralls

@Panaetius Panaetius enabled auto-merge (squash) December 2, 2024 14:33
@Panaetius Panaetius merged commit abc8ef5 into main Dec 2, 2024
11 of 12 checks passed
@Panaetius Panaetius deleted the tests-concurrency branch December 2, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants