Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: save storage secrets #567

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

olevski
Copy link
Member

@olevski olevski commented Dec 10, 2024

Migrating
SwissDataScienceCenter/renku-notebooks#1927

Depends on #566 and #565

Also will keep this as draft and resolve/merge only when the new data connectors code and secrets that @leafty is working on is merged.

@olevski olevski requested a review from a team as a code owner December 10, 2024 10:08
@olevski olevski marked this pull request as draft December 10, 2024 10:08
@Panaetius
Copy link
Member

would this be a good time to switch to direct calls in code instead of calling the data svc REST api from within data svc?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12253840387

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 22 of 61 (36.07%) changed or added relevant lines in 6 files are covered.
  • 8 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.07%) to 85.785%

Changes Missing Coverage Covered Lines Changed/Added Lines %
components/renku_data_services/notebooks/api/classes/k8s_client.py 6 12 50.0%
components/renku_data_services/notebooks/api/classes/data_service.py 2 10 20.0%
components/renku_data_services/notebooks/api/schemas/cloud_storage.py 1 11 9.09%
components/renku_data_services/notebooks/core.py 6 21 28.57%
Files with Coverage Reduction New Missed Lines %
components/renku_data_services/notebooks/api/classes/data_service.py 1 33.33%
components/renku_data_services/notebooks/api/schemas/cloud_storage.py 1 35.96%
components/renku_data_services/notebooks/api/classes/k8s_client.py 2 64.91%
components/renku_data_services/storage/blueprints.py 2 95.69%
components/renku_data_services/storage/models.py 2 84.11%
Totals Coverage Status
Change from base Build 12253732488: 0.07%
Covered Lines: 14556
Relevant Lines: 16968

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants