Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: manage v1 sessions #572

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

feat: manage v1 sessions #572

wants to merge 6 commits into from

Conversation

olevski
Copy link
Member

@olevski olevski commented Dec 11, 2024

This allows the notebook service to be fully retired.

/deploy renku-gateway=feat-shutdown-notebooks

depends on #569 and #571

@olevski olevski requested a review from a team as a code owner December 11, 2024 09:21
@olevski olevski marked this pull request as draft December 11, 2024 09:21
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ds-572.dev.renku.ch

@olevski olevski force-pushed the feat-run-notebooks-service branch from 448baca to 2418544 Compare December 11, 2024 12:21
@coveralls
Copy link

coveralls commented Dec 11, 2024

Pull Request Test Coverage Report for Build 12284868934

Details

  • 9 of 12 (75.0%) changed or added relevant lines in 4 files are covered.
  • 4 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.02%) to 86.381%

Changes Missing Coverage Covered Lines Changed/Added Lines %
components/renku_data_services/notebooks/api/classes/k8s_client.py 0 1 0.0%
components/renku_data_services/notebooks/api/classes/server.py 2 3 66.67%
components/renku_data_services/notebooks/core.py 5 6 83.33%
Files with Coverage Reduction New Missed Lines %
components/renku_data_services/base_api/misc.py 1 98.36%
components/renku_data_services/crc/blueprints.py 1 92.74%
components/renku_data_services/crc/models.py 1 84.71%
components/renku_data_services/notebooks/api/classes/k8s_client.py 1 58.39%
Totals Coverage Status
Change from base Build 12281701063: -0.02%
Covered Lines: 14633
Relevant Lines: 16940

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants