fix: image checks for some oci images failed #1995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This occurs because some images (most likely when they support multiple architectures) have an index instead of just a manifest. An OCI index refers to a set of images. But when we were checking for images we were only checking for the manifest and did not have the option to support an index content type.
olevski
force-pushed
the
fix-image-check-for-ghcr
branch
from
dcb5f72 to
aae7c56
Compare
|
This does not occur very often. I saw it only with this image: |
sgaist
previously approved these changes
Oct 16, 2024
|
You can access the deployment of this PR at https://renku-ci-nb-1995.dev.renku.ch |
SalimKayal
approved these changes
Oct 16, 2024
Panaetius
approved these changes
Oct 16, 2024
olevski
added a commit
that referenced
this pull request
Oct 16, 2024
This occurs because some images (most likely when they support multiple architectures) have an index instead of just a manifest. An OCI index refers to a set of images. But when we were checking for images we were only checking for the manifest and did not have the option to support an index content type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This occurs because some images (most likely when they support multiple architectures) have an index instead of just a manifest. An OCI index refers to a set of images. But when we were checking for images we were only checking for the manifest and did not have the option to support an index content type.
/deploy