Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle errors from the servers endpoint in the Dashboard #2873

Closed
lorenzo-cavazzi opened this issue Oct 31, 2023 · 0 comments · Fixed by #2903
Closed

Handle errors from the servers endpoint in the Dashboard #2873

lorenzo-cavazzi opened this issue Oct 31, 2023 · 0 comments · Fixed by #2903
Assignees
@leafty
Labels
UI board

Comments

@lorenzo-cavazzi
Copy link
Member

Description

The dashboard, and specifically the projects section, keeps refreshing at short intervals when the GET /servers endpoint from renku-notebooks fails to respond.
We should handle the error better and prevent this behavior. Best would be to show an error message so that users know sessions aren't currently shown.

Reproduce

Use the e2e tests, pick one for rendering the dashboard and remove the servers endpoint response (or fail it)

Screen.Recording.2023-10-31.at.10.25.09.mov
@leafty leafty self-assigned this Nov 7, 2023
@leafty leafty moved this from Todo to In Progress in Renku UI board Nov 10, 2023
@leafty leafty mentioned this issue Nov 17, 2023
Merged
leafty added a commit that referenced this issue Nov 20, 2023
@leafty
fix(client): handle errors from the getSessions query in the Dashboard (
aa826b4 
#2903)

Fixes #2873.

Introduces a new context and component to handle RTK Query errors in the case when nested components use an errored query.
@github-project-automation github-project-automation bot moved this from In Progress to Done in Renku UI board Nov 20, 2023
@leafty leafty mentioned this issue Nov 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leafty leafty

Labels
UI board
Projects
Renku UI board
Status: Done
Milestone
No milestone
2 participants
@leafty @lorenzo-cavazzi