-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(client): handle errors from the getSessions query in the Dashboard #2903
Conversation
You can access the deployment of this PR at https://renku-ci-ui-2903.dev.renku.ch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I add 3befaf0, but I am not sure if users will understand the error message. |
Oh, I meant something more generic, like a Warning saying "Sessions are currently unavailable" |
Done in 65d40d3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice solution!
I noticed the function extractRkErrorMessage
isn't working as expected. I'm unsure whether the Notebooks error is different from the Core error, or if something else is wrong in the logic there.
It would be great if you had some spare time to look at it. Otherwise, feel free to remove the specific error message and we can make a follow-up issue to fix the "RkErrorMessage" component(s) -- it would be great to have one that "just works", or to clearly distinguish between "renku-core" and "renku-notebooks" errors.
Some errors are handled, but others aren't (E.G. the renku-notebooks standard) |
Tearing down the temporary RenkuLab deplyoment for this PR. |
Fixes #2873.
Introduces a new context and component to handle RTK Query errors in the case when nested components use an errored query.
/deploy