feat: add get started & Who is Behind sections landing page anonymous users (#2891) #2896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andre-code
temporarily deployed
to
renku-ci-ui-2896
GitHub Actions
Inactive
|
You can access the deployment of this PR at https://renku-ci-ui-2896.dev.renku.ch |
andre-code
temporarily deployed
to
renku-ci-ui-2896
GitHub Actions
Inactive
andre-code
force-pushed
the
andrea/lp/2891-get-started-section
branch
from
933f59b to
8c82e8c
Compare
andre-code
temporarily deployed
to
renku-ci-ui-2896
GitHub Actions
Inactive
andre-code
force-pushed
the
andrea/lp/2891-get-started-section
branch
from
8c82e8c to
9e61ab3
Compare
andre-code
temporarily deployed
to
renku-ci-ui-2896
GitHub Actions
Inactive
andre-code
force-pushed
the
andrea/lp/2891-get-started-section
branch
from
9e61ab3 to
7b1dd2b
Compare
andre-code
temporarily deployed
to
renku-ci-ui-2896
GitHub Actions
Inactive
andre-code
force-pushed
the
andrea/lp/2891-get-started-section
branch
from
7b1dd2b to
30d2661
Compare
andre-code
had a problem deploying
to
renku-ci-ui-2896
GitHub Actions
Failure
andre-code
had a problem deploying
to
renku-ci-ui-2896
GitHub Actions
Failure
andre-code
had a problem deploying
to
renku-ci-ui-2896
GitHub Actions
Failure
andre-code
temporarily deployed
to
renku-ci-ui-2896
GitHub Actions
Inactive
andre-code
temporarily deployed
to
renku-ci-ui-2896
GitHub Actions
Inactive
andre-code
force-pushed
the
andrea/lp/2891-get-started-section
branch
from
30d2661 to
1a6a071
Compare
andre-code
temporarily deployed
to
renku-ci-ui-2896
GitHub Actions
Inactive
andre-code
force-pushed
the
andrea/lp/2891-get-started-section
branch
from
1a6a071 to
4207369
Compare
andre-code
temporarily deployed
to
renku-ci-ui-2896
GitHub Actions
Inactive
andre-code
force-pushed
the
andrea/lp/2891-get-started-section
branch
from
4207369 to
e96585a
Compare
andre-code
temporarily deployed
to
renku-ci-ui-2896
GitHub Actions
Inactive
andre-code
force-pushed
the
andrea/lp/2891-get-started-section
branch
from
e96585a to
d38263d
Compare
andre-code
temporarily deployed
to
renku-ci-ui-2896
GitHub Actions
Inactive
andre-code
force-pushed
the
andrea/lp/2891-get-started-section
branch
from
d38263d to
9e08835
Compare
andre-code
changed the base branch from
3357-redesign-landing-page
to
andrea/lp/2885-hero-section
andre-code
temporarily deployed
to
renku-ci-ui-2896
GitHub Actions
Inactive
andre-code
temporarily deployed
to
renku-ci-ui-2896
GitHub Actions
Inactive
andre-code
temporarily deployed
to
renku-ci-ui-2896
GitHub Actions
Inactive
andre-code
temporarily deployed
to
renku-ci-ui-2896
GitHub Actions
Inactive
lorenzo-cavazzi
approved these changes
Nov 24, 2023
There was a problem hiding this comment.
Regarding the message in the skeleton card when there is an error loading the project, I added it to quickly identify errors in deployment, such as missing the project path or an invalid path. The purpose is to quickly recognize the mistake and address it.
If the project isn't reachable anymore (E.G. accidentally deleted or otherwise not available) users will see the error.
In general, the UI should only show errors targeting users, not administrators. Those should be logged though Sentry instead.
Not blocking for merging the PR since we are short on time, but it would be nice to have this changed later.
andre-code
force-pushed
the
andrea/lp/2885-hero-section
branch
from
1d00d96 to
cd9d471
Compare
Base automatically changed from
andrea/lp/2885-hero-section
to
3357-redesign-landing-page
November 27, 2023 20:52
…leton and add back button from landing page
andre-code
force-pushed
the
andrea/lp/2891-get-started-section
branch
from
5f0b850 to
ca6cf9c
Compare
andre-code
force-pushed
the
andrea/lp/2891-get-started-section
branch
from
ca6cf9c to
b35394b
Compare
andre-code
temporarily deployed
to
renku-ci-ui-2896
GitHub Actions
Inactive
andre-code
temporarily deployed
to
renku-ci-ui-2896
GitHub Actions
Inactive
andre-code
temporarily deployed
to
renku-ci-ui-2896
GitHub Actions
Inactive
andre-code
had a problem deploying
to
renku-ci-ui-2896
GitHub Actions
Failure
andre-code
had a problem deploying
to
renku-ci-ui-2896
GitHub Actions
Failure
andre-code
had a problem deploying
to
renku-ci-ui-2896
GitHub Actions
Failure
lorenzo-cavazzi
approved these changes
Nov 28, 2023
andre-code
merged commit 9ee1bfb
into
3357-redesign-landing-page
28 of 33 checks passed
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
andre-code
added a commit
that referenced
this pull request
Nov 28, 2023
andre-code
added a commit
that referenced
this pull request
Nov 29, 2023
* feat(client): add hero section landing page anonymous users (#2885) (#2890) * feat(client): add get started & Who is Behind sections landing page anonymous users (#2891) (#2896) * feat(client): Add Teaching & What Is Renku sections landing page (#2911)(#2912) (#2913) * fix(client): Add project path and dataset slug home parameters for the landing page Fix #2895 #2891 #2897 #2911 #2912
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to add new getStarted and Who is Behind sections for landing page anonymous users.
Testing
To include or modify a project for testing the start session on the landing page, configure the HOMEPAGE_PROJECT_PATH in the client/run-telepresence.sh script.
No included here:
Fix #2891
Fix #2897
/deploy renku=2891-get-started-section extra-values=global.renku.cli_version=2.7.0 #persist