Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(client): use Vite instead of create-react-app #2924

Merged
merged 57 commits into from
Jan 10, 2024
Merged

refactor(client): use Vite instead of create-react-app #2924

merged 57 commits into from
Jan 10, 2024

Conversation

leafty
Copy link
Member

@leafty leafty commented Nov 27, 2023 •
edited
Loading

Fixes #2879.

Note: reviewing and merging can be delayed to after the next tagged release.

/deploy extra-values=global.renku.cli_version=2.8.0rc3

leafty added 30 commits November 17, 2023 14:41
@leafty
refactor(client): update to newest redux
0b535e1
@leafty
use typed hooks
4e81cc1
@leafty
remove App.test.js (rendering jest test)
00a10d1
@leafty
fix gnarly bug (?)
788014b
@leafty
refactor to fix redux issues
72b4ccb
@leafty
Merge remote-tracking branch 'origin/master' into leafty/upgrade-redux
e7817e0
@leafty
merge fixes
e861e6e
@leafty
refactor(client): use Vite instead of create-react-app
d2598e4
@leafty
try cypress ci/cd
1a0018f
@leafty
fix port
ea908ef
@leafty
Merge remote-tracking branch 'origin/master' into leafty/upgrade-redux
defefb8
@leafty
try to stabilize test
16746e8
@leafty
wip
6da16df
@leafty
wip: start configuring vitest
200ed3f
@leafty
make old jest tests work with vitest
6cca57f
@leafty
Merge remote-tracking branch 'origin/master' into leafty/refactor-vit…
2bfaad8 
…e-server
@leafty
fix ci/cd
b81e8b9
@leafty
make tsc and storybook work (maybe)
a606646
@leafty
small fixes
b69b0d5
@leafty
update tests
d5b42f1
@leafty
try
8ab7476
@leafty
more fixes
d5d433d
@leafty
fix?
d58b39e
@leafty
fix eslint
0cff1e5
@leafty
add bundle analyzer
9dee6b0
@leafty
update ci/cd
5bc98ca
@leafty
temporarily disable redux addon for storybook
8e65623
@leafty
introduce useLegacySelector()
d807414
@leafty
restore App.test.js
0e822eb
@leafty
fix tests
2439e6f
@leafty leafty temporarily deployed to renku-ci-ui-2924 December 6, 2023 15:32 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-2924 December 6, 2023 16:12 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-2924 December 7, 2023 10:11 — with GitHub Actions Inactive
@leafty leafty marked this pull request as ready for review December 7, 2023 10:49
@leafty leafty requested a review from a team as a code owner December 7, 2023 10:49
@leafty leafty temporarily deployed to renku-ci-ui-2924 December 7, 2023 10:50 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-2924 December 8, 2023 08:28 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-2924 December 8, 2023 13:00 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-2924 January 8, 2024 09:01 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-2924 January 8, 2024 09:43 — with GitHub Actions Inactive
ciyer
ciyer reviewed Jan 8, 2024
View reviewed changes
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: This is very good work here! A lot of tedious changes to enable this transition, but they are straightforward to follow.

Code-wise, there were two small things that I did not understand. I still need to run the branch locally, but the changes all made sense to me.

.github/workflows/test-and-ci.yml Show resolved Hide resolved
client/src/components/list/ListCard.stories.tsx Show resolved Hide resolved
@leafty leafty temporarily deployed to renku-ci-ui-2924 January 9, 2024 10:03 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-2924 January 9, 2024 10:39 — with GitHub Actions Inactive
ciyer
ciyer approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works very well. I tested running telepresence with the new config, and that worked, so I think this is ready to merge.

@leafty leafty merged commit 980d41f into master Jan 10, 2024
15 of 17 checks passed
@leafty leafty deleted the leafty/refactor-vite-server branch January 10, 2024 08:21
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciyer ciyer ciyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate from Create React App to Vite
3 participants
@leafty @RenkuBot @ciyer