feat(client): Update EntityCardSkeleton animation and add its storybook #2937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can access the deployment of this PR at https://renku-ci-ui-2937.dev.renku.ch |
andre-code
temporarily deployed
to
renku-ci-ui-2937
GitHub Actions
Inactive
andre-code
temporarily deployed
to
renku-ci-ui-2937
GitHub Actions
Inactive
andre-code
temporarily deployed
to
renku-ci-ui-2937
GitHub Actions
Inactive
leafty
reviewed
Dec 7, 2023
Comment on lines
99
to
103
| 0% { | ||
| background-position: -468px 0; | ||
| } | ||
| 100% { | ||
| background-position: 468px 0; |
There was a problem hiding this comment.
The animation start is not smooth:
Suggested change
| 0% { | |
| background-position: -468px 0; | |
| } | |
| 100% { | |
| background-position: 468px 0; | |
| 0% { | |
| background-position: -660px 0; | |
| } | |
| 100% { | |
| background-position: 400px 0; |
leafty
approved these changes
Dec 7, 2023
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR storybook for EntityCardSkeleton component.
Testing
npm run storybookor https://renku-ci-ui-2937.dev.renku.ch/storybook/?path=/story/components-loaders-entitycardskeleton--entity-card-skeleton-loader
Fix #2909
/deploy extra-values=global.renku.cli_version=2.8.0rc3 #persist