Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: indicate repository permissions in Renku 2.0 #3136

Merged
merged 17 commits into from
Jun 24, 2024
Merged

feat!: indicate repository permissions in Renku 2.0 #3136

merged 17 commits into from
Jun 24, 2024

Conversation

leafty
Copy link
Member

@leafty leafty commented May 21, 2024 •
edited
Loading

Add repository permissions indicators on the Renku 2.0 project page.

renku-ci-ui-3136 dev renku ch_v2_projects_flora thiebaut_flora-test (1)
renku-ci-ui-3136 dev renku ch_v2_projects_flora thiebaut_flora-test

BREAKING CHANGE: requires renku-data-services >= 0.14.0

See also: SwissDataScienceCenter/renku-data-services#197

/deploy renku=release-0.54.0

@leafty leafty temporarily deployed to renku-ci-ui-3136 May 21, 2024 12:19 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-3136.dev.renku.ch

@leafty leafty temporarily deployed to renku-ci-ui-3136 May 21, 2024 14:17 — with GitHub Actions Inactive
@leafty leafty force-pushed the leafty/repository-permissions branch from 15f7a6d to ba14f51 Compare May 22, 2024 09:40
@leafty leafty temporarily deployed to renku-ci-ui-3136 May 22, 2024 09:40 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3136 May 22, 2024 13:56 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3136 May 23, 2024 14:43 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3136 May 24, 2024 08:42 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3136 May 24, 2024 09:30 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3136 May 24, 2024 12:13 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3136 May 24, 2024 12:43 — with GitHub Actions Inactive
@leafty leafty mentioned this pull request May 24, 2024
Merged
@leafty leafty temporarily deployed to renku-ci-ui-3136 June 3, 2024 08:34 — with GitHub Actions Inactive
@leafty leafty changed the title feat: indicate repository permissions feat!: indicate repository permissions in Renku 2.0 Jun 6, 2024
@leafty leafty marked this pull request as ready for review June 6, 2024 12:45
@leafty leafty requested a review from a team as a code owner June 6, 2024 12:45
@leafty leafty temporarily deployed to renku-ci-ui-3136 June 6, 2024 12:47 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3136 June 6, 2024 13:03 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3136 June 10, 2024 11:14 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3136 June 20, 2024 12:31 — with GitHub Actions Inactive
lorenzo-cavazzi
lorenzo-cavazzi requested changes Jun 20, 2024
View reviewed changes
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature! 🚀

The code looks good! I added a couple of inline comments, just minor changes to add a few more interactions to the UX.

P.S. Including minimal cypress tests to cover the new code would be great.

client/src/features/ProjectPageV2/ProjectPageContent/CodeRepositories/CodeRepositoryDisplay.tsx Show resolved Hide resolved
client/src/features/ProjectPageV2/ProjectPageContent/CodeRepositories/CodeRepositoryDisplay.tsx Outdated Show resolved Hide resolved
client/src/features/ProjectPageV2/ProjectPageContent/CodeRepositories/CodeRepositoryDisplay.tsx Outdated Show resolved Hide resolved
client/src/features/ProjectPageV2/ProjectPageContent/CodeRepositories/CodeRepositoryDisplay.tsx Outdated Show resolved Hide resolved
@leafty leafty requested a review from lorenzo-cavazzi June 21, 2024 11:16
@leafty leafty temporarily deployed to renku-ci-ui-3136 June 21, 2024 11:17 — with GitHub Actions Inactive
lorenzo-cavazzi
lorenzo-cavazzi approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition to the project page 🚀

@leafty leafty merged commit 522fda3 into main Jun 24, 2024
19 of 23 checks passed
@leafty leafty deleted the leafty/repository-permissions branch June 24, 2024 09:01
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorenzo-cavazzi lorenzo-cavazzi lorenzo-cavazzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leafty @RenkuBot @lorenzo-cavazzi