Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: selenium tests to install CLI version fetched from core #3379

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jachro
Copy link
Collaborator

@jachro jachro commented Nov 21, 2023

This PR changes the behaviour of selenium tests in a way that they call the /api/renku/apiversion API and read the new cli_version property. This way the tests will always use CLI that is compatible (in fact the same) as installed on renku-core.

NOTICE:

      {{ if .Values.global.renku.cli_version }}
      - name: RENKU_CLI_VERSION
        value: '{{ .Values.global.renku.cli_version }}'
      {{ end }}

/deploy

@jachro jachro requested a review from a team as a code owner November 21, 2023 14:37
@RenkuBot
Copy link
Collaborator

You can access the deployment of this PR at https://ci-renku-3379.dev.renku.ch

@rokroskar
Copy link
Member

@jachro @Panaetius we should be able to merge this?

@jachro
Copy link
Collaborator Author

jachro commented Jan 31, 2024

@jachro @Panaetius we should be able to merge this?

A good question. I updated the PR and took out the link to renku-python branch. Let's see.

@jachro
Copy link
Collaborator Author

jachro commented Jan 31, 2024

The selenium mtests run and failed as the response from https://ci-renku-3379.dev.renku.ch/api/renku/apiversion

{"result":{"maximum_api_version":"2.2","latest_version":"2.9.1","supported_project_version":10,"minimum_api_version":"1.0"}}

didn't contain the expected cli_version property. @Panaetius was that change adding the property part of the lastest release on renku-python?

@rokroskar
Copy link
Member

@Panaetius I guess we can close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Observed
Development

Successfully merging this pull request may close these issues.

3 participants