-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: selenium tests to install CLI version fetched from core #3379
base: master
Are you sure you want to change the base?
Conversation
You can access the deployment of this PR at https://ci-renku-3379.dev.renku.ch |
@jachro @Panaetius we should be able to merge this? |
A good question. I updated the PR and took out the link to renku-python branch. Let's see. |
The selenium mtests run and failed as the response from https://ci-renku-3379.dev.renku.ch/api/renku/apiversion
didn't contain the expected |
@Panaetius I guess we can close this? |
This PR changes the behaviour of selenium tests in a way that they call the
/api/renku/apiversion
API and read the newcli_version
property. This way the tests will always use CLI that is compatible (in fact the same) as installed on renku-core.NOTICE:
helm-chart/renku/templates/tests/test-renku.yaml
; it cannot be done now as it will be brought with Update from auto-update/renku-graph-2.47.1 #3370./deploy