Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: various amalthea, helm chart and data service fixes #3846

Merged
merged 5 commits into from
Dec 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,35 @@
0.61.1
------

Renku 0.61.1 introduces a few bug fixes for the previous release.


User-Facing Changes
~~~~~~~~~~~~~~~~~~~

**🐞 Bug Fixes**

- **Sessions**: Properly launch sessions that have quotas

Internal Changes
~~~~~~~~~~~~~~~~

**Bug Fixes**

- **Amalthea**: Add resource requests for the authentication proxy containers
- **Amalthea**: Add support for setting priority classes for sessions
- **Data services**: Use the working directory to mount cloud storage if the mount path is relative
- **Data services**: Use HTTPS in the redirect URL for the authentication proxy
- **Data services**: Use GPU resource limits when GPUs are requested
- **Helm chart**: Do not set the default storage class to empty string if it is not set in the values file
- **Helm chart**: Restart the data services and notebooks pods when the mounted secret changes

Individual components
~~~~~~~~~~~~~~~~~~~~~~

- `amalthea 0.14.5 <https://github.com/SwissDataScienceCenter/amalthea/releases/tag/0.14.5>`_
- `amalthea 0.14.6 <https://github.com/SwissDataScienceCenter/amalthea/releases/tag/0.14.6>`_
- `renku-data-services 0.27.1 <https://github.com/SwissDataScienceCenter/renku-data-services/releases/tag/v0.27.1>`_


0.61.0
Expand Down
4 changes: 2 additions & 2 deletions helm-chart/renku/requirements.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ dependencies:
alias: jena
- name: amalthea
repository: "https://swissdatasciencecenter.github.io/helm-charts/"
version: "0.14.3"
version: "0.14.6"
- name: amalthea-sessions
repository: "https://swissdatasciencecenter.github.io/helm-charts/"
version: "0.14.4"
version: "0.14.6"
- name: dlf-chart
repository: "https://swissdatasciencecenter.github.io/datashim/"
version: "0.3.9-renku-2"
Expand Down
4 changes: 3 additions & 1 deletion helm-chart/renku/templates/data-service/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,10 @@ spec:
app: renku-data-service
release: {{ .Release.Name }}
{{ .Values.global.redis.clientLabel | toYaml | nindent 8 }}
{{- with .Values.dataService.podAnnotations }}
annotations:
# NOTE: Without this the pod will not restart when the secret values change.
checksum/config: {{ include (print $.Template.BasePath "/notebooks/env-secret.yaml") . | sha256sum }}
{{- with .Values.dataService.podAnnotations }}
{{- toYaml . | nindent 8 }}
{{- end }}
spec:
Expand Down
3 changes: 3 additions & 0 deletions helm-chart/renku/templates/notebooks/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ spec:
release: {{ .Release.Name }}
template:
metadata:
annotations:
# NOTE: Without this the pod will not restart when the secret values change.
checksum/config: {{ include (print $.Template.BasePath "/notebooks/env-secret.yaml") . | sha256sum }}
labels:
app: {{ template "renku.notebooks.name" . }}-k8s-watcher
chart: {{ template "renku.chart" . }}
Expand Down
4 changes: 2 additions & 2 deletions helm-chart/renku/templates/notebooks/env-secret.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ metadata:
type: Opaque
stringData:
NB_SESSIONS__STORAGE__PVS_ENABLED: {{ .Values.notebooks.userSessionPersistentVolumes.enabled | quote }}
{{ if .Values.notebooks.userSessionPersistentVolumes.enabled }}
{{- if and .Values.notebooks.userSessionPersistentVolumes.enabled .Values.notebooks.userSessionPersistentVolumes.storageClass }}
NB_SESSIONS__STORAGE__PVS_STORAGE_CLASS: {{ .Values.notebooks.userSessionPersistentVolumes.storageClass | quote}}
{{ end }}
{{- end }}
NB_SESSIONS__STORAGE__USE_EMPTY_DIR_SIZE_LIMIT: {{ .Values.notebooks.userSessionPersistentVolumes.useEmptyDirSizeLimit | quote }}
NB_SESSIONS__DEFAULT_IMAGE: "{{ .Values.notebooks.defaultSessionImage }}"
NB_SERVER_OPTIONS__DEFAULTS_PATH: /etc/renku-notebooks/server_options/server_defaults.json
Expand Down
6 changes: 3 additions & 3 deletions helm-chart/renku/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1595,14 +1595,14 @@ dataService:
create: true
image:
repository: renku/renku-data-service
tag: "0.27.0"
tag: "0.27.1"
pullPolicy: IfNotPresent
backgroundJobs:
events:
resources: {}
image:
repository: renku/data-service-background-jobs
tag: "0.27.0"
tag: "0.27.1"
pullPolicy: IfNotPresent
total:
resources: {}
Expand Down Expand Up @@ -1655,7 +1655,7 @@ authz:
secretsStorage:
image:
repository: renku/secrets-storage
tag: "0.27.0"
tag: "0.27.1"
pullPolicy: IfNotPresent
service:
type: ClusterIP
Expand Down
Loading