Skip to content

Commit

Permalink
minor #293 Bump Sylius 1.13 to stable v1.13.0 version (GSadee)
Browse files Browse the repository at this point in the history
This PR was merged into the master branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | master
| Bug fix?        | no
| New feature?    | yes
| Related tickets | 


Commits
-------
  Bump Sylius 1.13 to stable v1.13.0 version
  • Loading branch information
NoResponseMate authored Apr 23, 2024
2 parents 01b8dbc + d908cec commit e778a8e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,15 @@ jobs:
node: ["20.x"]
mysql: ["8.0"]
symfony: ["^5.4.21", "^6.4"]
sylius: ["~1.12.0", "~1.13.x-dev"]
sylius: ["~1.12.0", "~1.13.0"]
state_machine_adapter: ["winzou_state_machine", "symfony_workflow"]

include:
- php: "8.3"
node: "20.x"
mysql: "8.0"
symfony: "^6.4"
sylius: "~1.13.x-dev"
sylius: "~1.13.0"
state_machine_adapter: "symfony_workflow"

exclude:
Expand Down
7 changes: 3 additions & 4 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
"psr/http-client-implementation": "~1.0",
"psr/http-factory-implementation": "~1.0",
"sylius-labs/doctrine-migrations-extra-bundle": "^0.1.4 || ^0.2",
"sylius/state-machine-abstraction": "~1.13.x-dev",
"sylius/sylius": "~1.12.0 || ~1.13.x-dev",
"sylius/state-machine-abstraction": "~1.13.0",
"sylius/sylius": "~1.12.0 || ~1.13.0",
"symfony/mailer": "^5.4.21 || ^6.4"
},
"require-dev": {
Expand Down Expand Up @@ -84,6 +84,5 @@
"vendor/bin/ecs check src/ spec/ --fix"
]
},
"prefer-stable": true,
"minimum-stability": "dev"
"prefer-stable": true
}

2 comments on commit e778a8e

@TakesTheBiscuit
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this has caused a build failure on one of my projects

The service "Sylius\PayPalPlugin\Controller\Webhook\RefundOrderAction" has
a dependency on a non-existent service "sylius_abstraction.state_machine".

I will know more if i keep digging - but this change i think makes the dev-main branch unstable @NoResponseMate can you take a look to confirm too?

@NoResponseMate
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TakesTheBiscuit
Most likely the error you're getting is not caused by this, but is related.
For whatever reason our flex recipes didn't work in this case and did not add the bundle.
Should work alright as of this morning, but as a quick fix, you can add:

    Sylius\Abstraction\StateMachine\SyliusStateMachineAbstractionBundle::class => ['all' => true],

to your bundles.php file and it should work.

Please sign in to comment.