Skip to content

v1.2.2
Compare
Choose a tag to compare
@Zales0123 Zales0123 released this 09 Jul 12:37
v1.2.2
This tag was signed with the committer’s verified signature.
Zales0123 Mateusz Zalewski
GPG key ID: 9BECA0BB71612E52
Learn about vigilant mode.
c60b9a9
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Learn about vigilant mode.

Conflict with sylius/invoicing-plugin:<0.16.0

The reason for this config is the compatibility problem between plugins. Before this PR, Invoice was not directly related to order, but to its number, which is always generated after the checkout is completed. The invoice is also generated after the payment is paid.

In a regular checkout flow, there is no problem. However, it occurs when the payment is paid before the order is completed. Even though it's transparent for the user, when completing the order with PayPal from the Payment page, the payment is completed before the checkout (see this file):

$this->paymentStateManager->complete($payment);

// ...

$orderStateMachine->apply(OrderCheckoutTransitions::TRANSITION_COMPLETE);

Changing this order resulted in some additional issues, that would take more time and energy it's worth it. Especially, as the direct relation between Invoice and Order introduced in sylius/invoicing-plugin:>=0.16.0 solves the problem. Therefore, it's not possible to use this plugin with the previous SyliusInvoicingPlugin versions anymore 🖖

Assets 2
Loading