[Part] Improve Attacher updating on Accept #959
Syres916CI_master.yml
on: push
Prepare
/
Prepare
3s
Ubuntu_20-04
/
Build
13m 10s
Ubuntu_22-04
/
Build
14m 31s
Windows
/
Build
9m 43s
Lint
/
Lint
3m 43s
WrapUp
/
WrapUp
8s
Annotations
4 errors and 19 warnings
|
Lint / Lint
Process completed with exit code 1.
|
|
Lint / Lint:
src/Mod/Part/Gui/TaskAttacher.cpp#L52
'ui_TaskAttacher.h' file not found [clang-diagnostic-error]
|
|
Lint / Lint
Process completed with exit code 1.
|
|
Windows / Build
Process completed with exit code 1.
|
|
Prepare / Prepare
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Lint / Lint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Lint / Lint:
src/Mod/Part/Gui/TaskAttacher.cpp#L800
Missing space around colon in range-based for loop [whitespace/forcolon] [2]
|
|
Lint / Lint
fatal error: 'ui_TaskAttacher.h' file not found
|
|
Lint / Lint:
src/Mod/Part/Gui/TaskAttacher.cpp#L63
return type 'const QString' is 'const'-qualified at the top level, which may reduce code readability without improving const correctness [readability-const-return-type]
|
|
Lint / Lint:
src/Mod/Part/Gui/TaskAttacher.cpp#L65
statement should be inside braces [readability-braces-around-statements]
|
|
Lint / Lint:
src/Mod/Part/Gui/TaskAttacher.cpp#L69
statement should be inside braces [readability-braces-around-statements]
|
|
Lint / Lint:
src/Mod/Part/Gui/TaskAttacher.cpp#L76
do not use 'else' after 'return' [readability-else-after-return]
|
|
Lint / Lint:
src/Mod/Part/Gui/TaskAttacher.cpp#L79
6 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
|
|
Lint / Lint:
src/Mod/Part/Gui/TaskAttacher.cpp#L79
6 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
|
|
Lint / Lint:
src/Mod/Part/Gui/TaskAttacher.cpp#L80
6 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
|
|
Lint / Lint:
src/Mod/Part/Gui/TaskAttacher.cpp#L90
2 adjacent parameters of 'makeRefStrings' of similar type ('int &') are easily swapped by mistake [bugprone-easily-swappable-parameters]
|
|
Lint / Lint
note: the first parameter in the range is 'refstrings'
|
|
Lint / Lint
note: the last parameter in the range is 'refnames'
|
|
Windows / Build
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/cache/restore@v3, pat-s/always-upload-cache@v3, microsoft/[email protected], actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Ubuntu_20-04 / Build
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, pat-s/always-upload-cache@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Ubuntu_22-04 / Build
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, pat-s/always-upload-cache@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
WrapUp / WrapUp
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/download-artifact@v3, geekyeggo/delete-artifact@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "Lint-11192245922-Logs", "Prepare-11192245922-Logs", "Ubuntu_20-04-11192245922-Logs", "Ubuntu_22-04-11192245922-Logs", "Windows-11192245922-Logs".
Please update your workflow to use v4 of the artifact actions.
Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
Lint-11192245922-Logs
|
67 KB |
|
|
Prepare-11192245922-Logs
|
16.6 KB |
|
|
Ubuntu_20-04-11192245922-Logs
|
1.32 MB |
|
|
Ubuntu_22-04-11192245922-Logs
|
1.33 MB |
|
|
Windows-11192245922-Logs
|
1.52 MB |
|