Skip to content

[Sketcher] Update string comparison from C to C++ #1050

[Sketcher] Update string comparison from C to C++

[Sketcher] Update string comparison from C to C++ #1050

Triggered via pull request November 16, 2024 12:25
Status Success
Total duration 4h 52m 46s
Artifacts 8

CI_master.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

3 errors and 60 warnings
Lint / Lint
Process completed with exit code 2.
Lint / Lint
Process completed with exit code 2.
WrapUp / WrapUp
$GITHUB_STEP_SUMMARY upload aborted, supports content up to a size of 1024k, got 1898k. For more information see: https://docs.github.com/actions/using-workflows/workflow-commands-for-github-actions#adding-a-markdown-summary
Lint / Lint
NCollection_ListNode has copy-ctor, copy-assignment but not dtor [-Wclazy-rule-of-three]
Lint / Lint
Pass small and trivially-copyable type by value (const class NCollection_BaseList::Iterator &) [-Wclazy-function-args-by-value]
Lint / Lint
Pass small and trivially-copyable type by value (const class NCollection_BaseList::Iterator &) [-Wclazy-function-args-by-value]
Lint / Lint
Pass small and trivially-copyable type by value (const class gp_XY &) [-Wclazy-function-args-by-value]
Lint / Lint
Pass small and trivially-copyable type by value (const class gp_XY &) [-Wclazy-function-args-by-value]
Lint / Lint
Pass small and trivially-copyable type by value (const class gp_XY &) [-Wclazy-function-args-by-value]
Lint / Lint
Pass small and trivially-copyable type by value (const class gp_XY &) [-Wclazy-function-args-by-value]
Lint / Lint
Pass small and trivially-copyable type by value (const class gp_XY &) [-Wclazy-function-args-by-value]
Lint / Lint
Pass small and trivially-copyable type by value (const class gp_XY &) [-Wclazy-function-args-by-value]
Lint / Lint
Pass small and trivially-copyable type by value (const class gp_XY &) [-Wclazy-function-args-by-value]
Lint / Lint: src/Mod/Sketcher/App/SketchObject.cpp#L216
10.0 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
Lint / Lint: src/Mod/Sketcher/App/SketchObject.cpp#L240
statement should be inside braces [readability-braces-around-statements]
Lint / Lint: src/Mod/Sketcher/App/SketchObject.cpp#L242
statement should be inside braces [readability-braces-around-statements]
Lint / Lint: src/Mod/Sketcher/App/SketchObject.cpp#L244
statement should be inside braces [readability-braces-around-statements]
Lint / Lint: src/Mod/Sketcher/App/SketchObject.cpp#L246
statement should be inside braces [readability-braces-around-statements]
Lint / Lint: src/Mod/Sketcher/App/SketchObject.cpp#L255
statement should be inside braces [readability-braces-around-statements]
Lint / Lint: src/Mod/Sketcher/App/SketchObject.cpp#L285
do not use 'else' after 'return' [readability-else-after-return]
Lint / Lint: src/Mod/Sketcher/App/SketchObject.cpp#L295
5 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
Lint / Lint: src/Mod/Sketcher/App/SketchObject.cpp#L311
parameter name 's' is too short, expected at least 2 characters [readability-identifier-length]
Lint / Lint: src/Mod/Sketcher/App/SketchObject.cpp#L312
statement should be inside braces [readability-braces-around-statements]
MacOS_13_Conda_Apple / Build
Input 'save-always' has been deprecated with message: save-always does not work as intended and will be removed in a future release. A separate `actions/cache/restore` step should be used instead. See https://github.com/actions/cache/tree/main/save#always-save-cache for more details.
MacOS_13_Conda_Apple / Build
/Users/runner/miniconda3/lib/python3.12/site-packages/conda/base/context.py:198: FutureWarning: Adding 'defaults' to channel list implicitly is deprecated and will be removed in 25.3. To remove this warning, please choose a default channel explicitly with conda's regular configuration system, e.g. by adding 'defaults' to the list of channels: conda config --add channels defaults For more information see https://docs.conda.io/projects/conda/en/stable/user-guide/configuration/use-condarc.html deprecated.topic(
MacOS_13_Conda_Apple / Build
The 'defaults' channel might have been added implicitly. If this is intentional, add 'defaults' to the 'channels' list. Otherwise, consider setting 'conda-remove-defaults' to 'true'.
MacOS_13_Conda_Apple / Build
/Users/runner/miniconda3/lib/python3.12/argparse.py:2006: FutureWarning: `remote_definition` is deprecated and will be removed in 25.9. Use `conda env create --file=URL` instead. action(self, namespace, argument_values, option_string)
MacOS_13_Conda_Apple / Build
INFO conda.conda_libmamba_solver.solver:_log_info(377): conda version: 24.9.2
MacOS_13_Conda_Apple / Build
INFO conda.conda_libmamba_solver.solver:_log_info(378): conda-libmamba-solver version: 24.9.0
MacOS_13_Conda_Apple / Build
INFO conda.conda_libmamba_solver.solver:_log_info(379): libmambapy version: 1.5.9
MacOS_13_Conda_Apple / Build
INFO conda.conda_libmamba_solver.solver:_log_info(380): Target prefix: '/Users/runner/work/FreeCAD/FreeCAD/.conda/freecad'
MacOS_13_Conda_Apple / Build
INFO conda.conda_libmamba_solver.solver:_log_info(381): Command: ['/Users/runner/miniconda3/condabin/mamba', 'create', '--prefix', '.conda/freecad', '--file', 'conda/conda-env.yaml']
MacOS_13_Conda_Apple / Build
info libmamba Reading repodata.json file "/var/folders/g6/rgtlsw6n123b0gt5483s5_cm0000gn/T/tmphq1yo01f.json" for repo installed
MacOS_13_Conda_Apple / Build
INFO conda.gateways.repodata.jlap.fetch:download_and_hash(265): Download 0 bytes {'User-Agent': 'conda/24.9.2 requests/2.32.3 CPython/3.12.7 Darwin/23.6.0 OSX/14.7 solver/libmamba conda-libmamba-solver/24.9.0 libmambapy/1.5.9', 'Accept-Encoding': 'gzip, deflate, br, zstd', 'Accept': '*/*', 'Connection': 'keep-alive'}
MacOS_13_Conda_Apple / Build
Input 'save-always' has been deprecated with message: save-always does not work as intended and will be removed in a future release. A separate `actions/cache/restore` step should be used instead. See https://github.com/actions/cache/tree/main/save#always-save-cache for more details.
Ubuntu_20-04 / Build
Input 'save-always' has been deprecated with message: save-always does not work as intended and will be removed in a future release. A separate `actions/cache/restore` step should be used instead. See https://github.com/actions/cache/tree/main/save#always-save-cache for more details.
Ubuntu_20-04 / Build
Input 'save-always' has been deprecated with message: save-always does not work as intended and will be removed in a future release. A separate `actions/cache/restore` step should be used instead. See https://github.com/actions/cache/tree/main/save#always-save-cache for more details.
Ubuntu_22-04_Conda / Build
Input 'save-always' has been deprecated with message: save-always does not work as intended and will be removed in a future release. A separate `actions/cache/restore` step should be used instead. See https://github.com/actions/cache/tree/main/save#always-save-cache for more details.
Ubuntu_22-04_Conda / Build
/home/runner/miniconda3/lib/python3.12/site-packages/conda/base/context.py:198: FutureWarning: Adding 'defaults' to channel list implicitly is deprecated and will be removed in 25.3. To remove this warning, please choose a default channel explicitly with conda's regular configuration system, e.g. by adding 'defaults' to the list of channels: conda config --add channels defaults For more information see https://docs.conda.io/projects/conda/en/stable/user-guide/configuration/use-condarc.html deprecated.topic(
Ubuntu_22-04_Conda / Build
The 'defaults' channel might have been added implicitly. If this is intentional, add 'defaults' to the 'channels' list. Otherwise, consider setting 'conda-remove-defaults' to 'true'.
Ubuntu_22-04_Conda / Build
/home/runner/miniconda3/lib/python3.12/argparse.py:2006: FutureWarning: `remote_definition` is deprecated and will be removed in 25.9. Use `conda env create --file=URL` instead. action(self, namespace, argument_values, option_string)
Ubuntu_22-04_Conda / Build
INFO conda.conda_libmamba_solver.solver:_log_info(377): conda version: 24.9.2
Ubuntu_22-04_Conda / Build
INFO conda.conda_libmamba_solver.solver:_log_info(378): conda-libmamba-solver version: 24.9.0
Ubuntu_22-04_Conda / Build
INFO conda.conda_libmamba_solver.solver:_log_info(379): libmambapy version: 1.5.9
Ubuntu_22-04_Conda / Build
INFO conda.conda_libmamba_solver.solver:_log_info(380): Target prefix: '/home/runner/work/FreeCAD/FreeCAD/.conda/freecad'
Ubuntu_22-04_Conda / Build
INFO conda.conda_libmamba_solver.solver:_log_info(381): Command: ['/home/runner/miniconda3/condabin/mamba', 'create', '--prefix', '.conda/freecad', '--file', 'conda/conda-env.yaml']
Ubuntu_22-04_Conda / Build
INFO conda.gateways.repodata.jlap.fetch:download_and_hash(265): Download 728241 bytes {'User-Agent': 'conda/24.9.2 requests/2.32.3 CPython/3.12.7 Linux/6.5.0-1025-azure ubuntu/22.04.5 glibc/2.35 solver/libmamba conda-libmamba-solver/24.9.0 libmambapy/1.5.9', 'Accept-Encoding': 'gzip, deflate, br, zstd', 'Accept': '*/*', 'Connection': 'keep-alive'}
Ubuntu_22-04_Conda / Build
INFO conda.gateways.repodata.jlap.fetch:request_url_jlap_state(432): Apply 0 patches 44389ef6d36bb4cc… → 44389ef6d36bb4cc…
Ubuntu_22-04_Conda / Build
Input 'save-always' has been deprecated with message: save-always does not work as intended and will be removed in a future release. A separate `actions/cache/restore` step should be used instead. See https://github.com/actions/cache/tree/main/save#always-save-cache for more details.
Ubuntu_22-04_Conda_Qt6 / Build
Input 'save-always' has been deprecated with message: save-always does not work as intended and will be removed in a future release. A separate `actions/cache/restore` step should be used instead. See https://github.com/actions/cache/tree/main/save#always-save-cache for more details.
Ubuntu_22-04_Conda_Qt6 / Build
Input 'save-always' has been deprecated with message: save-always does not work as intended and will be removed in a future release. A separate `actions/cache/restore` step should be used instead. See https://github.com/actions/cache/tree/main/save#always-save-cache for more details.
Ubuntu_22-04_Conda_Qt6 / Build
/home/runner/miniconda3/lib/python3.12/site-packages/conda/base/context.py:198: FutureWarning: Adding 'defaults' to channel list implicitly is deprecated and will be removed in 25.3. To remove this warning, please choose a default channel explicitly with conda's regular configuration system, e.g. by adding 'defaults' to the list of channels: conda config --add channels defaults For more information see https://docs.conda.io/projects/conda/en/stable/user-guide/configuration/use-condarc.html deprecated.topic(
Ubuntu_22-04_Conda_Qt6 / Build
The 'defaults' channel might have been added implicitly. If this is intentional, add 'defaults' to the 'channels' list. Otherwise, consider setting 'conda-remove-defaults' to 'true'.
Ubuntu_22-04_Conda_Qt6 / Build
/home/runner/miniconda3/lib/python3.12/argparse.py:2006: FutureWarning: `remote_definition` is deprecated and will be removed in 25.9. Use `conda env create --file=URL` instead. action(self, namespace, argument_values, option_string)
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.conda_libmamba_solver.solver:_log_info(377): conda version: 24.9.2
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.conda_libmamba_solver.solver:_log_info(378): conda-libmamba-solver version: 24.9.0
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.conda_libmamba_solver.solver:_log_info(379): libmambapy version: 1.5.9
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.conda_libmamba_solver.solver:_log_info(380): Target prefix: '/home/runner/work/FreeCAD/FreeCAD/.conda/freecad'
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.conda_libmamba_solver.solver:_log_info(381): Command: ['/home/runner/miniconda3/condabin/mamba', 'create', '--prefix', '.conda/freecad', '--file', 'conda/conda-env-qt6.yaml']
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.gateways.repodata.jlap.fetch:download_and_hash(265): Download 728241 bytes {'User-Agent': 'conda/24.9.2 requests/2.32.3 CPython/3.12.7 Linux/6.5.0-1025-azure ubuntu/22.04.5 glibc/2.35 solver/libmamba conda-libmamba-solver/24.9.0 libmambapy/1.5.9', 'Accept-Encoding': 'gzip, deflate, br, zstd', 'Accept': '*/*', 'Connection': 'keep-alive'}
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.gateways.repodata.jlap.fetch:request_url_jlap_state(432): Apply 0 patches 44389ef6d36bb4cc… → 44389ef6d36bb4cc…
Windows / Build
Input 'save-always' has been deprecated with message: save-always does not work as intended and will be removed in a future release. A separate `actions/cache/restore` step should be used instead. See https://github.com/actions/cache/tree/main/save#always-save-cache for more details.
Windows / Build
Input 'save-always' has been deprecated with message: save-always does not work as intended and will be removed in a future release. A separate `actions/cache/restore` step should be used instead. See https://github.com/actions/cache/tree/main/save#always-save-cache for more details.

Artifacts

Produced during runtime
Name Size
Lint-11870060093-Logs
115 KB
MacOS_13_Conda_Apple-11870060093-Logs
45 KB
Prepare-11870060093-Logs
5.02 KB
Ubuntu_20-04-11870060093-Logs
184 KB
Ubuntu_22-04_Conda-11870060093-Logs
241 KB
Ubuntu_22-04_Conda-Qt6-11870060093-Logs
239 KB
Ubuntu_22-04_Conda-Qt6-11870060093-report.md
3.76 KB
Windows-11870060093-Logs
2.78 MB