Skip to content

[Gui] Handle 16 to 32 bit PNG files #1057

[Gui] Handle 16 to 32 bit PNG files

[Gui] Handle 16 to 32 bit PNG files #1057

Triggered via push November 29, 2024 13:52
Status Failure
Total duration 1h 17m 2s
Artifacts 5

CI_master.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

1 error and 11 warnings
Windows / Build
Process completed with exit code 1.
Lint / Lint: src/Gui/BitmapFactory.cpp#L52
do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays,modernize-avoid-c-arrays]
Lint / Lint: src/Gui/BitmapFactory.cpp#L52
variable 'not_found' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
Lint / Lint: src/Gui/BitmapFactory.cpp#L90
variable '_pcSingleton' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
Lint / Lint: src/Gui/BitmapFactory.cpp#L90
variable '_pcSingleton' provides global access to a non-const object; consider making the pointed-to data 'const' [cppcoreguidelines-avoid-non-const-global-variables]
Lint / Lint: src/Gui/BitmapFactory.cpp#L96
assigning newly created 'gsl::owner<>' to non-owner 'Gui::BitmapFactoryInst *' [cppcoreguidelines-owning-memory]
Lint / Lint: src/Gui/BitmapFactory.cpp#L98
static member accessed through instance [readability-static-accessed-through-instance]
Lint / Lint: src/Gui/BitmapFactory.cpp#L99
static member accessed through instance [readability-static-accessed-through-instance]
Lint / Lint: src/Gui/BitmapFactory.cpp#L118
'if' statement is unnecessary; deleting null pointer has no effect [readability-delete-null-pointer]
Lint / Lint: src/Gui/BitmapFactory.cpp#L118
statement should be inside braces [readability-braces-around-statements]
Lint / Lint: src/Gui/BitmapFactory.cpp#L119
deleting a pointer through a type that is not marked 'gsl::owner<>'; consider using a smart pointer instead [cppcoreguidelines-owning-memory]
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "Lint-12085942926-Logs", "Prepare-12085942926-Logs", "Ubuntu_20-04-12085942926-Logs", "Ubuntu_22-04-12085942926-Logs", "Windows-12085942926-Logs". Please update your workflow to use v4 of the artifact actions. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

Artifacts

Produced during runtime
Name Size
Lint-12085942926-Logs
71 KB
Prepare-12085942926-Logs
20.1 KB
Ubuntu_20-04-12085942926-Logs
1.61 MB
Ubuntu_22-04-12085942926-Logs
1.61 MB
Windows-12085942926-Logs
1.71 MB