Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: char, string and cell array input #415

Merged
merged 23 commits into from
May 13, 2022
Merged

Conversation

edkerk
Copy link
Member

@edkerk edkerk commented May 2, 2022

Main improvements in this PR:

  • feat:

  • fix:

    • MAFFT: explicitly force mafft.bat to be handled as binary, to prevent end-of-line character changes when checking out on Windows

I hereby confirm that I have:

@github-actions
Copy link

github-actions bot commented May 2, 2022

This PR has been automatically tested with GH Actions. Here is the output of the tests:

 Running blastPlusTests . Done blastPlusTests 
 Running cdhitTests . Done cdhitTests 
 Running diamondTests . Done diamondTests 
 Running fillGapsLargeTests . 
 Error occurred in fillGapsLargeTests/testLargeCobra and it did not run to completion. 
 Error ID: 
 '' 
 Error Details: 
 Error using setRavenSolver (line 19) COBRA toolbox is not initialized, run 'initCobraToolbox()' Error in fillGapsLargeTests>testLargeCobra (line 85) setRavenSolver('cobra'); 
 . Done fillGapsLargeTests 
 Running fillGapsSmallTests .. 
 Error occurred in fillGapsSmallTests/testSmallCobra and it did not run to completion. 
 Error ID: 
 '' 
 Error Details: 
 Error using setRavenSolver (line 19) COBRA toolbox is not initialized, run 'initCobraToolbox()' Error in fillGapsSmallTests>testSmallCobra (line 85) setRavenSolver('cobra'); 
 . Done fillGapsSmallTests 
 Running hmmerTests . Done hmmerTests 
 Running importExportTests .... Done importExportTests 
 Running mafftTests . Done mafftTests 
 Running miriamTests . Done miriamTests 
 Running modelAbilitiesTests .. testOut = struct with fields: np: [16x1 double] npn: {16x1 cell} nfpm: [16x16 logical] mtc: {9x1 cell} testOut = struct with fields: np: [16x1 double] npn: {16x1 cell} nfpm: [16x16 logical] mtc: {9x1 cell} testOut = struct with fields: np: [16x1 double] npn: {16x1 cell} nfpm: [16x16 logical] mtc: {9x1 cell} testOut = struct with fields: np: [16x1 double] npn: {16x1 cell} nfpm: [16x16 logical] mtc: {9x1 cell} ...... Done modelAbilitiesTests 
 Running modelConversionTests . Done modelConversionTests 
 Running modelCurationTests .......... ....... Done modelCurationTests 
 Running solverTests .. 
 Error occurred in solverTests/testCobra and it did not run to completion. 
 Error ID: 
 '' 
 Error Details: 
 Error using solverTests>testCobra (line 95) Solver not working 
 . Done solverTests 
 Running sortIdentifiers_and_permuteModelTests . Done sortIdentifiers_and_permuteModelTests 
 Running tinitTests . Done tinitTests 
 Failure Summary: Name Failed Incomplete Reason(s) 
 fillGapsLargeTests/testLargeCobra X X Errored. 
 fillGapsSmallTests/testSmallCobra X X Errored. 
 solverTests/testCobra X X Errored.

Note: In the case of multiple test runs, this post will be edited.

@edkerk edkerk marked this pull request as draft May 2, 2022 07:35
@edkerk edkerk marked this pull request as ready for review May 4, 2022 21:42
@edkerk edkerk requested a review from johan-gson May 6, 2022 07:24
@edkerk
Copy link
Member Author

edkerk commented May 12, 2022

cd to the testing\unit_tests folder and run runtests(struct2table(dir('*.m')).name);

@edkerk edkerk requested a review from feiranl May 12, 2022 15:57
Copy link
Contributor

@johan-gson johan-gson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the test cases on my computer using
"runtests(struct2table(dir('*.m')).name)" - all but the mafft tests worked, which according to Ed was fine.

@edkerk edkerk merged commit 940aca0 into devel May 13, 2022
@edkerk edkerk deleted the refactor/charAndStringInput branch May 13, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants