-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: char, string and cell array input #415
Conversation
- all functions in this commit are tested by a unit_test
This PR has been automatically tested with GH Actions. Here is the output of the tests:
|
cd to the |
# Conflicts: # doc/core/compareMultipleModels.html # doc/core/index.html # doc/index.html # doc/io/exportForGit.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the test cases on my computer using
"runtests(struct2table(dir('*.m')).name)" - all but the mafft tests worked, which according to Ed was fine.
Main improvements in this PR:
feat:
'example'
) and string arrays ("example"
) as input when text strings are expected (solves refactor: allow string parameters to be given as string array #397)fix:
mafft.bat
to be handled as binary, to prevent end-of-line character changes when checking out on WindowsI hereby confirm that I have:
devel
as a target branch