Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/WG-285: update potree converter #218

Merged
merged 28 commits into from
Oct 28, 2024

Conversation

nathanfranklin
Copy link
Collaborator

@nathanfranklin nathanfranklin commented Sep 12, 2024

Overview:

This PR bumps Potree Converter.

This PR does the following:

  • reworks Dockerfile for workers
    • uses Ubuntu as the base image (instead of an older PDAL image)
    • installs conda and installs PDAL via conda
  • bumps Potree Converter version

Related Jira tickets:

  • WG-285 - issue with loading Oso_MiniRanger_ULS_20240315.laz

Summary of Changes:

Testing Steps:

  1. Build the updated image: make build
  2. Run hazmapper and import a laz point cloud and confirm that it converted and the viewer works file
  3. If you want to test with Oso_MiniRanger_ULS_20240315.laz, a copy is in https://designsafe-ci.org/data/browser/projects/PRJ-4576

Notes:

TODO

  • We pinged RAPID for additional testing on Oct 4th as this bumps the potree viewer from 1.6 to 1.8 and curious if everything works as expected for their use cases. It is deployed to staging for their testing.
  • update deployed nginx conf
  • confirm which version of potreeconvert (going with c2328c4 which is v2.1.1 with some additional fixes)
  • confirm if we need LAStools still for building PotreeConverter

@nathanfranklin nathanfranklin marked this pull request as draft September 12, 2024 18:18
@nathanfranklin nathanfranklin marked this pull request as ready for review September 17, 2024 14:51
devops/Dockerfile.worker Outdated Show resolved Hide resolved
Copy link
Contributor

@sophia-massie sophia-massie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tested locally. Thanks for the changes

nathanfranklin added a commit to TACC-Cloud/wma-geospatial-deployments that referenced this pull request Oct 2, 2024
@nathanfranklin nathanfranklin merged commit f50e8e9 into main Oct 28, 2024
3 checks passed
@nathanfranklin nathanfranklin deleted the task/WG-285-update-potree-converter branch October 28, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants