task/wg-166-questionnaire-preview-title #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanfranklin
requested changes
Nov 28, 2023
There was a problem hiding this comment.
Nice! Fixing the titles of all assets is going to be excellent 🥳 . I have left some comments to address/consider.
Regarding the one comment related to feature.properties.label and `title', I'm gonna hunt down older hazmapper v1 geojson and get back to you on that.
angular/src/app/components/asset-detail/asset-detail.component.ts
Outdated
Show resolved
Hide resolved
angular/src/app/components/modal-questionnaire-viewer/modal-questionnaire-viewer.component.styl
Outdated
Show resolved
Hide resolved
selected tree node property, and use the activeFeature subscription instead to pull the file name. Added a function to extract file name from activeFeature display_path.
angular/src/app/components/asset-detail/asset-detail.component.ts
Outdated
Show resolved
Hide resolved
angular/src/app/components/asset-detail/asset-detail.component.ts
Outdated
Show resolved
Hide resolved
nathanfranklin
added a commit
that referenced
this pull request
Dec 18, 2023
* task/WG-96 add assets to original questionnaire code (#144) * Do not show _hazmapper properties * Add ng-bootstrap to use carousel * Add carasol to show questionnaire assets * User correct version of npm so lock file doesn't change * Switch CI to match our container's version of node * Refactor into a component * Remove bootstrap * Use own-carousel for image asset carousel * Fix linting * Remove unintended blank line * Revert "Switch CI to match our container's version of node" This reverts commit 357027a. * Fix weird formatting issues * Revert "Revert "Switch CI to match our container's version of node"" This reverts commit 4077c5a. * task/WG-173:show asset image alongside question in the questionnaire (#165) * Show asset images with questions * Fix prettier errors * Remove reduntant types from JSDoc strings * task/WG-167: Overhaul questionnaire style (#169) * Initial commit to get the Questionnaire redesign rolling. Initial resize of the modal window to begin improving layout and styles. * Added comment to evolving styles. * Initial pass removing all font-sizes and color form the questionnaire modal. Next is to prune out the margins and spacing. Need clean, unstyled text in the UI to build new CSS back up on. * Removed all font weighting, font type assignments and font size assignments from selectors in questionnaire modal. * Commented out most of the styling in the questionnaire at this point. * Have now commented out all styles that are not required for basic structure. Purging unused code next. * Removed all unused selectors from the .styl document for questionnaire viewer. Ready to rebuild the style back up now. * Completed the initial rebuild of the Questionnaire viewer styles to integrate with the Hazmapper design aesthetic. Still working on a few question types - ranged options specifically - but otherwise clean layout now. * Added styling for the rangeAnswer elements. None of the questionnaire content indicates a selected state so I set a value anyway in case we update the view code to include that attribute. * Changes the scope of image selectors in the questionnaire to only style images embedded within the questionnaire modal. Added support for both rangeSelect question and matrixTable question styling. Adjusted overall font sizes and layout for better legibility and use of white-space. * Ran linting on the css. * Cleaned up a mistake in css. Linting seems to regenerate unused style code locally. Investigating, but this commit is clean. * task/wg-166-questionnaire-preview-title (#171) * task/wg-166-questionnaire-preview-title * Added padding for detail header for long titles * Linting * Prettier linting * Revert style linting * Remove event emitters, select node event and selected tree node property, and use the activeFeature subscription instead to pull the file name. Added a function to extract file name from activeFeature display_path. * Remove unused import * Take file naming out of try block * Remove diff * A quick tweak to the Sub-question styling to clean it up a little and add some padding. (#174) * Fix z-index of asset-detail so its below modal (#173) * Task/wg 174 & 175 improve right panel questionnaire pic scroll and metadata (#176) * task/WG-174-Improve-right-panel-questionnaire-metadata * Used FeatureType() function to get find questionnaire assets and consolidated logic * task/WG-188: fix questionnaire detail panel (#177) * Fix questionnaire-detail so it updates when feature changes Also handle the cae where there are no properites._hazmapper.questionnaire.asset because it is a questionnaire without assets * Handle case when no feature is active * Fix linting * Rework layout of questionnaire to take all space (#178) * Rework layout of questionnaire to take all space * Fix linting * Disable custom analytics-related headers (#179) * Task/WG-171: Fix location question on questionnaire map (#186) * Make map fill up the map container * Add marker on location map --------- Co-authored-by: John Gentle <[email protected]> Co-authored-by: sophia-massie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
PR Status:
Related Jira tickets:
Summary of Changes:
Testing Steps:
UI Photos:
Other assets
Questionnaire
