feat: tup-700 @tacc/core-components node pkg #239
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem was forgetting to build core-components before packing.
wesleyboar
added a commit
to TACC/tup-ui
that referenced
this pull request
May 20, 2024
TACC-Cloud/hazmapper's only form crashed. If checkbox is removed, then now it doesn't. Expect checkbox fix in next commit. TACC-Cloud/hazmapper#239
wesleyboar
added a commit
to TACC/tup-ui
that referenced
this pull request
May 20, 2024
TACC-Cloud/hazmapper's only checkbox field crashed. Now it doesn't. TACC-Cloud/hazmapper#239
Problem was… core-components not coded/tested for external usage. Fixes in TACC/tup-ui: TACC/tup-ui@cb73d54 TACC/tup-ui@836f372
wesleyboar
added a commit
to TACC/tup-ui
that referenced
this pull request
May 20, 2024
TACC-Cloud/hazmapper's only form crashed. If checkbox is removed, then now it doesn't. Expect checkbox fix in next commit. TACC-Cloud/hazmapper#239
wesleyboar
added a commit
to TACC/tup-ui
that referenced
this pull request
May 20, 2024
TACC-Cloud/hazmapper's only checkbox field crashed. Now it doesn't. TACC-Cloud/hazmapper#239
This was referenced May 20, 2024
|
@wesleyboar , ugh, i don't know why i closed this. probably was absent mindedly closed it when closing some dependbot PRs. 🤦 |
1 task
|
@nathanfranklin, okie dokie. Gotta make new PR, I think cuz Re-opened as #264. |
wesleyboar
added a commit
to TACC/tup-ui
that referenced
this pull request
Oct 18, 2024
* fix: revert FormikFieldWrapper→FieldWrapperFormik * fix: support .js imports * chore: use index.js when component is .jsx * fix: make FormikCheck useField like other fields * fix: FieldWrapper… TACC-Cloud/Hazmapper form crash TACC-Cloud/hazmapper's only form crashed. If checkbox is removed, then now it doesn't. Expect checkbox fix in next commit. TACC-Cloud/hazmapper#239 * fix: FieldWrapper… TACC-Cloud/Hazmapper checkbox TACC-Cloud/hazmapper's only checkbox field crashed. Now it doesn't. TACC-Cloud/hazmapper#239 * fix: FormikCheck not supporting ID attr * chore: npx nx format:write * fix: FieldWrapper… ID fallback support incomplete * fix: remove unused prop * refactor: use Formik field wrappers as components * fix: FieldWrapper… ID fallback support STILL incomplete * docs: update author, add contributors * Move to peer dependencies (#484) * Move to peer dependencies Also add vite for building as we want to make stand-alone * Make 0.0.3 prelease * Bump postcss and postcss-preset-env to match core styles requirements * Fix pretty issue * Add vite-plugin-lib-inject-css * Make uuid only as a dependeny allow any 8 or 9 version --------- Co-authored-by: Wesley B <[email protected]> --------- Co-authored-by: Nathan Franklin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Replace
core-componentsandcore-wrapperswith upcoming @tacc/core-components.Status
Important
Moved to #264.
Archived
useFormikContextTACC/tup-ui@836f372
TACC/tup-ui@cb73d54
useLocation()in the context of a<Router>PR Status:
Related Jira tickets:
Summary of Changes:
core-componentsandcore-wrappers@tacc/core-components(test of local install)core-…to use@tacc/core-componentscore-componentsandcore-wrappersTesting Steps:
npm install --save ../../tacc-core-components-0.0.1.tgz1UI Photos:
…
Footnotes
You can get the package by following "Testing" "0." in https://github.com/TACC/tup-ui/pull/464. ↩