task/WG-232-React-Listing-UI #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Brings over EmptyTablePlaceholder from TUP UI that CMD collaborated with us on
type 'NonNullable<ReactNodeLike>' error in unit test
sophia-massie
changed the title
nathanfranklin
requested changes
Oct 18, 2024
error handling, removed global styles to apply at end
sophia-massie
commented
Oct 30, 2024
- Centers error and no data messages - Linting - TODO hover behavior
…Cloud/hazmapper into task/WG-232-React-Listing-UI-clean
- Adds width for error message
- Addresses incomplete merge - Adds style so icon changes color on hover
|
Ready for another review |
nathanfranklin
added a commit
that referenced
this pull request
Nov 11, 2024
* Add initial feature file tree * Additional work on assets list * Add sorting * Improve doc * Improve styling and fix nodes of tree * Add todo * Refactor and add test * Refactor into new files * Move FeatureFileNode into types * Use font awesome for folder icon * Fix spelling error * Rework importing * Expand rows * Set witch of panel as 230px * Remove todos * Ensure nodes are expanded at start * Fix selection/hover and height of rows * Fix expanding rows on refresh * Add selected feature to route and fix row spacing * Add useDelete From #268 * Add functionality for feature deletion * Refactor MapProject * Fix todos * Add isLoading to button * Allow user to export feature geojson to file * Add feature icon in asset listing * Refactor types related to feature icon * Add missing useDeleteFeature * Add unit testing of getFeatureType * Fix linting * Add AssetsPanel test * Add FeatureFileTree unit test * Bump testing-library/react to get rid of act warnings * Removed unused * Add antd * Switch to antd tree instead of react-table * Fix accessibility-related warnings and fix unit tests * Adjust width and overflow * Fix height issues * Improve navbar * Remove deprecated typs/antd. Types are included already with antd * Limit getting features to a single time * Fix scaling of panel container * Rework tree to deal with virtual rendering issues 4px bottom butter was being added to each node which caused an issue in calculating how much vertical space was needed to render nodes. * Make nav bar scrolling when y overflows * Make contents of project view take up space below nav/control bar * Removed unneeded config and styles * Move hazmapper globals to hazmapper.css * Add missing file * Update act import * Fix bad merge --------- Co-authored-by: Author: sophia-massie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
PR Status:
Related Jira tickets:
Summary of Changes:
Uses styles from Hazmapper angular to create Project Listing and cleans up the main project listing page
Testing Steps:
UI Photos:
Error message:
No projects message:
Notes: