Implement faded (configurable colour) zeroes in the Hex Editor #4098
Conversation
..if this is even a possibility
|
|
|
|
| @@ -20,6 +20,7 @@ private void HexColors_Form_Load(object sender, EventArgs e) | |||
| HexFreeze.BackColor = _hexEditor.Colors.Freeze; | |||
| HexFreezeHL.BackColor = _hexEditor.Colors.HighlightFreeze; | |||
| HexHighlight.BackColor = _hexEditor.Colors.Highlight; | |||
| Hex00.BackColor = _hexEditor.Colors.Foreground00; | |||
There was a problem hiding this comment.
Maybe use Zeroes in identifiers instead of 00
| this.colorDialog1 = new System.Windows.Forms.ColorDialog(); | ||
| this.label7 = new BizHawk.WinForms.Controls.LocLabelEx(); | ||
| this.Hex00 = new System.Windows.Forms.Panel(); | ||
| this.colorDialog1 = new System.Windows.Forms.ColorDialog(); |
There was a problem hiding this comment.
Whitespace noise can be cleaned up. If you want I can do it immediately before merge.
| if (AddressesLabel.ZeroColor != Colors.Foreground00) | ||
| { | ||
| AddressesLabel.ZeroColor = Colors.Foreground00; | ||
| } |
There was a problem hiding this comment.
I don't think this belongs here
| <ItemGroup> | ||
| <Compile Update="LabelEx\HexLabelEx.cs"> | ||
| <SubType>Component</SubType> | ||
| </Compile> |
There was a problem hiding this comment.
Does this have any effect? If so then I'd expect the rest of the controls in this project to be missing their IDE icons or whatever, since they're obviously not listed here.
|
|
||
| namespace BizHawk.WinForms.Controls | ||
| { | ||
| /// <inheritdoc cref="Docs.LabelOrLinkLabel"/> |
There was a problem hiding this comment.
Should add a <seealso/> to those docs
| foreach (string line in lines) | ||
| { | ||
| // split left and right panes | ||
| string[] panes = line.Split('|'); |
There was a problem hiding this comment.
Really don't like this. The caller has full knowledge of the content that's being passed in and should be able to make separate calls before or instead of passing in a concatenated line.
YoshiRulz
changed the title
|
This does not work when the data size isn't 1 byte. |
|
Sounds like this needs a lot more work. It should probably integrate with the highlighting positioning code in the calling class. I'll work on it when I have time. |
This implements a HexLabelEx control that replaces the LocaLabelEx 'AddressesLabel' control in HexEditor.cs.
It overrides OnPaint(), parses the incoming string and draws the string out using different colours depending on whether the hex value is '00' or not.
A new colour selector is also implemented within HexColor.cs so the user can choose which colour they want displayed for 00 values.
This addresses #3769 and the duplicate #3930
Notes:
I'm sure it can all be cleaned up, but I'm stuck at the moment on the 'how'.