-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ffmpeg presets #4111
base: master
Are you sure you want to change the base?
Update ffmpeg presets #4111
Conversation
- Adjusts sorting and naming - Removes presets that likely nobody uses - MP4 becomes a "Social Media" preset with better compatibility and streaming support - AVC MKV now uses FLAC instead of uncompressed audio
new FormatPreset("AVI Lossless UT Video", "Lossless UT video and uncompressed audio in an AVI container. Compatible with AVISource(), if UT Video decoder is installed. Fast, but low compression.", | ||
new FormatPreset("Social Media — MP4", "Optimized for quick and easy sharing. Produces small, highly compatible and streamable files. AVC video and Opus audio in a MP4 container.", | ||
"-c:a libopus -c:v libx264 -pix_fmt yuv420p -movflags +faststart -f mp4", false, "mp4"), | ||
new FormatPreset("[ Custom ]", "Write your own FFmpeg command. For advanced users only.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd still keep this at the bottom due to its unique nature.
"-c:a pcm_s16le -c:v utvideo -pred median -pix_fmt gbrp -f avi", false, "avi"), | ||
new FormatPreset("AVI Lossless FFV1", "Lossless FFV1 video and uncompressed audio in an AVI container. Compatible with AVISource(), if ffmpeg based decoder is installed. Slow, but high compression.", | ||
new FormatPreset("Lossless FFV1 — AVI", "Lossless FFV1 video and uncompressed audio in an AVI container. Slow, but high compression. Compatible with AVISource(), if FFmpeg based decoder is installed.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since FFV1 decoders seem to break all other VFW codecs (until you fix the registry, which then breaks the FFV1 decoder), I wonder if it's time to drop this option in favor of Ut.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Source? Also this is ffmpeg, not vfw.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can't use ffmpeg to encode TASes with avisynth. avisynth depends on VFW decoders. VFW decoder for ffmpeg dumps breaks other VFW codecs.
"-c:a aac -c:v libx264 -f flv", false, "flv"), | ||
new FormatPreset("[Custom]", "Write your own ffmpeg command. For advanced users only.", | ||
customCommand, true, "foobar") | ||
new FormatPreset("Uncompressed — AVI", "Uncompressed video and audio in an AVI container. Extremely large files, don't use!", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't remember this ever having value either (during my 14 years of encoding TASes).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep uncompressed AVI please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're using it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not at the moment, but I believe it's important to have an extremely simple encoding option for troubleshooting. (I'm now realising there's a separate AVI writer, but it's not available on Linux, so my point stands.)
I would very much prefer if this is not done. Your "likely completely unused" covers some presets I've used before, and I would guess these might be used by a few other users. |
Notable: It defaults to a sample rate of 48kHz. I know that deviates from the 44.1kHz that BizHawk uses but i don't think that is really a concern for this use case.
All presets decode without issue in VLC, MPV, Handbrake and when uploaded to YouTube.
Sidenote: Custom is the only preset that accepts changes but you can still edit the command of the other presets. That is kind of misleading because those changes are not applied when starting the encode.