-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DSi NWRAM Support #454
base: master
Are you sure you want to change the base?
DSi NWRAM Support #454
Conversation
Guarded by define DSI_NEWWRAM, which is currently only set for the VS Studio Project
…y the default initialization, which might not be valid in all compiler settings)
Not sure how I feel about adding pieces of DSI emulation that will just sit incomplete and bitrot. Isn't this like 1/1000th of the work it takes to get DSI stuff booting? |
I am a bit baffled and confused by this response. But let's first try fact based argument:
Then there are the social elements of these words you have chosen: I was always a fan of cooperating and returning, which I do with this PR and those intended to follow, but I am in no way required to do so. So please, teke it or leave it, but this above is an offending, lazy formulated comment. |
When desmume was being iteratively improved, things were different. It was a sleek schooner with a crack crew. Now it's a barnacled shipwreck. Each improvement is a new layer of crust that weights it further into the seafloor. |
It's a barnacled shipwreck that I and many others came to love over the years! Good and decent Nintendo DS emulators doesn't grow on trees and thankfully DeSmuME plays all the games I have pretty much perfectly which I'm really grateful for because there is not much else worth using at the moment. Also, I don't see the need to down talk on the project all the time, like it's a pain in the ass. If you, the author behind the project is incapable of loving or taking care of the project, how are you expecting future DeSmuME users to love it and having a great time time with it. |
I added the support of the new shared WRAM in the DSi.
The support is quarded by the define DSI_NEWWRAM. For the VS Project this define is set, for all other builds this is not set and thus disabled. Please add this define to the build-scripts, when the commit is approved and shall be included in the project.
The code takes care of the NWRAM priority as the hardware:
NWRAM Set A < NWRAM Set B < NWRAM Set C < OldWRAM
This is different than no$gba but consistent with hardware. No$gba places internal arm7 wram infront of the NWRAM.
The following edge-cases are NOT consistent with hardware:
Test .NDS:
nwramTest.zip
Results:
Compare no$gba: