remove some defensive ArgumentNullExceptions that nullable reference …

…types sufficiently warn about
TASVideos · Mar 23, 2024 · 5f2c0da · 5f2c0da
1 parent 78afdf8
commit 5f2c0da
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 25 deletions.
diff --git a/TASVideos.Common/Extensions/EnumerableExtensions.cs b/TASVideos.Common/Extensions/EnumerableExtensions.cs
@@ -31,11 +31,6 @@ public static IEnumerable<T> SecondHalf<T>(this IEnumerable<T> source)
 	/// </summary>
 	public static T AtRandom<T>(this ICollection<T> collection)
 	{
-		if (collection is null)
-		{
-			throw new ArgumentNullException($"{nameof(collection)} can not be null");
-		}
-
 		var randomIndex = new Random(DateTime.UtcNow.Millisecond).Next(0, collection.Count);
 		return collection.ElementAt(randomIndex);
 	}

diff --git a/TASVideos/Extensions/HtmlHelperExtensions.cs b/TASVideos/Extensions/HtmlHelperExtensions.cs
@@ -9,16 +9,6 @@ public static class HtmlHelperExtensions
 {
 	public static IHtmlContent DescriptionFor<TModel, TValue>(this IHtmlHelper<TModel> html, Expression<Func<TModel, TValue>> expression)
 	{
-		if (html is null)
-		{
-			throw new ArgumentNullException(nameof(html));
-		}
-
-		if (expression is null)
-		{
-			throw new ArgumentNullException(nameof(expression));
-		}
-
 		var expressionProvider = html.ViewContext.HttpContext.RequestServices.GetRequiredService<ModelExpressionProvider>();
 		var modelExpression = expressionProvider.CreateModelExpression(html.ViewData, expression);
 

diff --git a/TASVideos/Extensions/HttpRequestExtensions.cs b/TASVideos/Extensions/HttpRequestExtensions.cs
@@ -10,11 +10,6 @@ public static class HttpRequestExtensions
 
 	public static bool IsAjaxRequest(this HttpRequest request)
 	{
-		if (request is null)
-		{
-			throw new ArgumentNullException(nameof(request));
-		}
-
 		return request.Headers[RequestedWithHeader] == XmlHttpRequest;
 	}
 

diff --git a/TASVideos/Models/CommaSeparatedModelBinder.cs b/TASVideos/Models/CommaSeparatedModelBinder.cs
@@ -20,11 +20,6 @@ public class DelimitedQueryStringValueProvider(
 
 	public override ValueProviderResult GetValue(string key)
 	{
-		if (key is null)
-		{
-			throw new ArgumentNullException(nameof(key));
-		}
-
 		var values = _queryCollection[key];
 		if (values.Count == 0)
 		{