rate-limit submissions #1736
Merged
rate-limit submissions #1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to be only a soft limit, a client limit, right? So for example someone opening 20 tabs of the submission page could still submit them all one after another? |
|
Woops... |
decide if allowed to submit by count of those
…ubmit probably needs to tell them it didn't go through?
stop hardcoding notice lines
adelikat
reviewed
Jan 5, 2024
| _earliestTimestamp.AddDays(_settings.SubmissionRate.Days) | ||
| }; | ||
|
|
||
| public bool SubmissionAllowed(int userId) |
adelikat
approved these changes
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you attempt to submit by going from sub list page to SubmitMovie, I replace the entire page with the notice telling how much you need to wait, if you're beyond the limit. The limit is configured in appsettings.
I doubt it's done properly, but should be fixable.
fix #1709