Revert "escape formatting symbols for discord publisher" #1753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit df97a92. The commit implemented a very simple way of escaping by simply putting a backslash in front of every character allowing custom formatting.
The reason for this revert is a bug in Discord Markdown formatting:
Inside masked links, instead of hiding the escape backslashes like everywhere else, it instead shows them.
There is no way to prevent formatting inside masked links.
I reported a bug to Discord using their bug report tool. I also looked around in different places and it seems they keep this bug for "security reasons" discord/discord-api-docs#6185 (comment) , even if all other Markdowns do it right.
For example it works in GitHub Markdown:
*format*-> format\*escaped\*-> *escaped*[*format*](http://a.b)-> format[\*wtfdiscord\*](http://a.b)-> *wtfdiscord*