Implement text for wikiLink module #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adelikat
approved these changes
Feb 4, 2024
nattthebear
approved these changes
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1760 . (Text missing from Youtube Descriptions)
Also resolves Text missing from TOC, which is a different method.
This implements InnerText of __wikiLinks being href if displaytext is empty. (For TOCs)
It also implements RenderTextAsync by using the same method as InvokeAsync, but only taking the display name. (For Youtube)
NOTE: One problem remaining is that on YouTube, the wiki links won't be a link, only text. That's because I can't format it into the
displaytext ( href )format, as with links, because I don't have thewriterHelperthat is used to convert the href to a full url. Trying to inject it givesSystem.InvalidOperationException: Unable to resolve service for type 'TASVideos.WikiEngine.AST.IWriterHelper' while attempting to activate 'TASVideos.ViewComponents.WikiLink'.However, a non-link is better than no text at all.