Add [module:PublicationsByPlatform]

[YoshiRulz]

resolves #1910

[adelikat]

@YoshiRulz : how is this PR coming along? the code looks good

[YoshiRulz]

It's finished (helps if I commit before pushing). The problem is #1910 (comment)

[...the output] differs from the manual table in that it doesn't group any platforms together (list taken from IGameSystemService).
edit: ALSO I didn't implement feos' suggestion of checking for and omitting empty lists, so it differs from the manual table in that way too.

[adelikat]

Yeah that grouping is not any concept we have in our database, and we would lose it if we used the module instead. How important is it @vadosnaprimer ?

[vadosnaprimer]

If grouping functionality is added to the module it'd be an overkill?

[module:PublicationsByPlatform|GB,GBC,SGB|NES,FDS|DS,DSi]

[vadosnaprimer]

Turns out we already have modules that have grouping. Example

[module:displaymovie|flag=verified|systemCode=gb,gbc,gba|obs]

I believe the same should be done here.

[module:PublicationsByPlatform|Groups=GB-GBC-SGB,NES-FDS,DS-DSi]

[YoshiRulz]

You can test with

[module:PublicationsByPlatform|groupings=A2600-A7800,Jaguar-JaguarCD,GB-SGB-GBC,DOS-DOOM-Windows-Linux,MSX-SVI3x8,NES-FDS,N64-N64DD,DS-DSi,Genesis-32X-SegaCD,SMS-GG-SG1000,SNES-BSX,PCE-PCECD-SGX]

[vadosnaprimer]

Grouping works!!!

Is it a big DB hit if only non-empty lists are shown?

[YoshiRulz]

IDK ask adelikat

edit:

it woudl be a query per system, plus caching, or a complex query
either way, I'd recommend avoiding it for now

[Masterjun3]

Is this local function necessary here? It seems to be called only once, and it makes the entire method more difficult to parse and understand, because I have to keep going up and down to see what things are affected where.

[YoshiRulz]

It's that or goto, since C# doesn't have multi-break.

edit: I considered having the method return a List<...>? and then conditionally appending to rows in the outer loop; do you think that would be better?