Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to Sync verify Submissions #1975

Merged
merged 11 commits into from
Sep 2, 2024
Merged

Ability to Sync verify Submissions #1975

merged 11 commits into from
Sep 2, 2024

Conversation

adelikat
Copy link
Collaborator

@adelikat adelikat commented Sep 1, 2024

No description provided.

@Masterjun3
Copy link
Collaborator

I personally think some of the terms collide here. We have "Console Verify" that people already know, and now there is "Sync Verify". So when something is called "IsVerified" or a filter is called "Show Verified" I think it will cause confusion. It should probably always include the term "Sync".

@Masterjun3
Copy link
Collaborator

Also, there are some console.logs in the javascript code, maybe they should be removed before merging.

@adelikat adelikat merged commit eedd67b into main Sep 2, 2024
1 check passed
@adelikat adelikat deleted the sync-verify branch September 2, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants