Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor frontend improvements for search results page #1999

Closed
wants to merge 2 commits into from

Conversation

YoshiRulz
Copy link
Collaborator

No description provided.

@vadosnaprimer
Copy link
Collaborator

Can you post before/after pics?

@YoshiRulz
Copy link
Collaborator Author

before
before
after
after

@vadosnaprimer
Copy link
Collaborator

So just spacing?

@Spikestuff
Copy link
Contributor

So just spacing?

The "..." move across, was that intentional, and why?

@YoshiRulz
Copy link
Collaborator Author

<tr><td style="padding-inline-start: 3em; user-select: none;">&hellip;</td></tr>

And the reason was to make it even clearer that it's not one of the results.

@vadosnaprimer
Copy link
Collaborator

vadosnaprimer commented Oct 3, 2024

And the reason was to make it even clearer that it's not one of the results.

I don't believe anyone would seriously think ... without a link is a publication/game.

@adelikat adelikat requested a review from vadosnaprimer October 8, 2024 21:25
@adelikat
Copy link
Collaborator

adelikat commented Nov 2, 2024

Closing because this UI change was not desired by staff

@adelikat adelikat closed this Nov 2, 2024
@YoshiRulz
Copy link
Collaborator Author

The game groups really need a separator. How about ','?

-<a asp-page="/GameGroups/Index" asp-route-id="@group.Id">@group.Name</a>
+<a asp-page="/GameGroups/Index" asp-route-id="@group.Id" class="game-search-result-group">@group.Name</a>
+.game-search-result-group:not(:last-of-type)::after {
+	color: var(--bs-body-color);
+	content: ",";
+}

@Masterjun3
Copy link
Collaborator

Can you make a screenshot of what exactly needs a separator? I don't seem to understand what the issue is.
If it's more elaborate we can also make a new issue ticket about this.

@vadosnaprimer
Copy link
Collaborator

изображение

изображение

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants