Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some metrics configuration #2021

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Add some metrics configuration #2021

merged 1 commit into from
Oct 22, 2024

Conversation

Masterjun3
Copy link
Collaborator

This PR does two things to our metrics:

  1. Disable the duration histograms for each endpoint. This reduces our 1MB 4000 line data file down to just 45kB and 250 lines.
  2. Make the db call histogram more precise. Previously the lowest precision was 5 seconds of db time. But most of our calls are below that. The actual values for the buckets are taken from the standard.

@adelikat adelikat self-requested a review October 22, 2024 19:15
@adelikat adelikat merged commit c698ec9 into main Oct 22, 2024
1 check passed
@adelikat adelikat deleted the metrics-reducedata-improveprecision branch October 22, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adelikat adelikat adelikat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Masterjun3 @adelikat