Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nv12 UI #89

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Nv12 UI #89

wants to merge 20 commits into from

Conversation

satgit62
Copy link

@satgit62 satgit62 commented Dec 3, 2024

NV12 settings selection implementation.

In the new hyperion-webos, the backends have been extended to include nv12 video format, so that NV12/YUV can also be passed on to the Hyperion or HyperHDR instead of RGB.
As a result, I have added a nv12 selection checkbox to the UI. In addition, hyperion-webos submodules would have to be linked to the latest https://github.com/webosbrew/hyperion-webos.

PicCap_nv12

PicCap hyperion-webos submodule

@Dak0r
Copy link

Dak0r commented Dec 26, 2024

Hey, code looks good to me. I built it locally and seems to work, with the correct version of the webos backend.
Any reason, why you didn't include the submodule update in this branch? In my opinion, it's a requirement to merge this.

I am not sure, if we want to mention somewhere that HyperHDR v21 is required for this, as it won't work with the current v20 stable release?

@@ -298,6 +299,7 @@ window.serviceResetSettings = () => {

vsync: true,
autostart: false,
nv12: true,
Copy link

@Dak0r Dak0r Dec 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the hyperhdr stable release (v20) does not support it, yet, defaulting to false would be a more fitting default for now, imo

@satgit62
Copy link
Author

Hey, code looks good to me. I built it locally and seems to work, with the correct version of the webos backend. Any reason, why you didn't include the submodule update in this branch? In my opinion, it's a requirement to merge this.

I am not sure, if we want to mention somewhere that HyperHDR v21 is required for this, as it won't work with the current v20 stable release?

Hello,
I originally assigned the submodules from @sundermann, but there were errors when compiling, and so I removed them again, hoping @TBSniller would comment.
See: https://github.com/satgit62/piccap/tree/nv12
In the end, I swapped the backends manually.

@Dak0r
Copy link

Dak0r commented Dec 26, 2024

I was able to build your piccap branch with the submodule updated to the latest main branch commit from sundermann, without problems. Which error did you get?

(Note: I had to update cmake in my WSL to >=3.24, because hyperion-webos is now using DOWNLOAD_EXTRACT_TIMESTAMP in its CMakeFile)

@satgit62
Copy link
Author

I was able to build your piccap branch with the submodule updated to the latest main branch commit from sundermann, without problems. Which error did you get?

(Note: I had to update cmake in my WSL to >=3.24, because hyperion-webos is now using DOWNLOAD_EXTRACT_TIMESTAMP in its CMakeFile)

Yes, if you build on PC it works with cmake update good (hint) but in GitHub when pushing an action the IPK is not built. See: https://github.com/satgit62/piccap/actions/runs/12156806035/job/33901240141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants