-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nv12 UI #89
base: main
Are you sure you want to change the base?
Nv12 UI #89
Conversation
Hey, code looks good to me. I built it locally and seems to work, with the correct version of the webos backend. I am not sure, if we want to mention somewhere that HyperHDR v21 is required for this, as it won't work with the current v20 stable release? |
@@ -298,6 +299,7 @@ window.serviceResetSettings = () => { | |||
|
|||
vsync: true, | |||
autostart: false, | |||
nv12: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the hyperhdr stable release (v20) does not support it, yet, defaulting to false
would be a more fitting default for now, imo
Hello, |
I was able to build your piccap branch with the submodule updated to the latest main branch commit from sundermann, without problems. Which error did you get? (Note: I had to update cmake in my WSL to >=3.24, because hyperion-webos is now using |
Yes, if you build on PC it works with cmake update good (hint) but in GitHub when pushing an action the IPK is not built. See: https://github.com/satgit62/piccap/actions/runs/12156806035/job/33901240141 |
NV12 settings selection implementation.
In the new hyperion-webos, the backends have been extended to include nv12 video format, so that NV12/YUV can also be passed on to the Hyperion or HyperHDR instead of RGB.
As a result, I have added a nv12 selection checkbox to the UI. In addition, hyperion-webos submodules would have to be linked to the latest https://github.com/webosbrew/hyperion-webos.