Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure VERSION file is present before reading it. #615

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Conversation

sydb
Copy link
Member

@sydb sydb commented May 27, 2023

Honestly, I am not entirely sure why we are reading a file rather than having the version number hard-coded in, say, common/common_params.xsl. But in any case, I have:

  • Updated tei:stylesheetVersion() with a fix based on @eduarddrenth’s suggestion.
  • Removed parameter from that function defintion, it was not being used.
  • Removed parameter from the 1 call to that function.
  • Some whitespace changes, too.
  • Fixed my e-mail addr in AUTHORS.
  • Updated expected-results/ to match mildly different comment at the end.

I am afraid I cannot assign @eduarddrenth as a reviewer.

 * Update tei:stylesheetVersion() with a fix based on @eduarddrenth’s suggestion.
 * Remove parameter from that function defintion, it was not being used.
 * Remove parameter from the 1 call to tath function.
 * Some whitespace, too.
 * Fixed my e-mail addr in AUTHORS.
 * Updated expected-results/ to match mildly different comment at the end.
@sydb sydb added the type: bug A bug report. label May 27, 2023
@sydb sydb added this to the Release 7.56.0 milestone May 27, 2023
I do not understand how these files were missed when I tested prior to previous commit, but fixing anyway ...
@sabineseifert
Copy link
Contributor

Talking about e-mail addresses in AUTHORS: Shouldn't we delete Sebastian's e-mail address in line 3?

@sydb
Copy link
Member Author

sydb commented Aug 10, 2023

Good point. Probably should re-write that whole first para. Perhaps something like

The main author of these XSL stylesheets was
the late Sebastian Rahtz from the University
of Oxford IT Services. The TEI Consortium is
forever in his debt for this invaluable con-
tribution.

@ebeshero ebeshero merged commit 120b12b into dev Nov 10, 2023
4 checks passed
@raffazizzi raffazizzi added this to the Release 7.56.0 milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A bug report.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants