fix errors in docxtotei noticed by Stylesheets group #634
Conversation
2) Fix typo — function had "#teitodocx" where it meant "#docxtotei"
sydb
added
type: bug
| @@ -20,7 +20,7 @@ | |||
| </fileDesc> | |||
| <encodingDesc> | |||
| <appInfo> | |||
| <application xml:id="docxtotei" ident="TEI_fromDOCX" version="2.15.0"> | |||
There was a problem hiding this comment.
To avoid such non-updated version statements, wouldn't it be nice to automatically update them on build or on release and, e.g., just fill in a placeholder here?
There was a problem hiding this comment.
@bwbohl I think we've addressed this: We've added a rule to read the current version number in the Stylesheets in docxtotei.xsl.
| <xsl:template name="generateAppInfo"> | ||
| <appInfo> | ||
| <xsl:variable name="version" | ||
| select="if ( unparsed-text-available('../../VERSION') ) |
There was a problem hiding this comment.
@bwbohl Here's where we made the change!
There was a problem hiding this comment.
That looks good!
Nevertheless, what I was getting at is manually maintaining TEI files in Test/expected-results/ vs. having a placeholder there for the value of @verison and then, when a text is executed, updating it on the fly from the VERSION-file; in the sense of "preparing" or "building" the test prior to execution. Doing so would guarantee that the expected-results @version is always in sync with the current VERSION and avoid the test from failing just due to the value of @version.
There was a problem hiding this comment.
Right, @bwbohl. That’s what I thought you might have meant. I think you are absolutely right. But I do not think we plan to do anything to improve comparison to files in Test/expected-results/, because I think we are going to stop using Test/ (in favor of using what is now called Test2/). There we will probably need to change the cleanForDiff target to remove that @version.
While discussing #610 the Stylesheets group noticed two minor bugs, which this PR is intended to address.