Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: fix spelling #644

Merged
merged 1 commit into from
Nov 20, 2023
Merged

misc: fix spelling #644

merged 1 commit into from
Nov 20, 2023

Conversation

jbampton
Copy link
Contributor

No description provided.

@martindholmes
Copy link
Contributor

I see an error in Test (make test) with test31, but Test2 passes OK.

@martindholmes
Copy link
Contributor

@jbampton The error in Test is caused by my bugfix in the Stylesheets today: the addition of ul.simple{ list-style-type: none; } to tei.css. If you merge dev into your branch the problem should go away.

@jbampton
Copy link
Contributor Author

Hey @martindholmes I think the branch is up to date:

https://github.com/jbampton/TEIC-Stylesheets/commits/fix-spelling

@martindholmes
Copy link
Contributor

@jbampton In that case it's the expected-results that need an update to take account of the change to tei.css, I think.

@martindholmes
Copy link
Contributor

@jbampton My mistake -- I had forgotten to commit my changes to Test resulting from my own fix for issue #534. I've done that now; if the Jenkins build for Stylesheets-dev confirms the problem is fixed, then a pull from dev will sort it out.

@martindholmes
Copy link
Contributor

@jbampton Stylesheets-dev build is now working, so please pull again.

@jbampton
Copy link
Contributor Author

Thanks @martindholmes all done now

sydb
sydb approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@sydb sydb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests in both Test/ and Test2/ pass on my system.

@trishaoconnor trishaoconnor self-assigned this Nov 20, 2023
@trishaoconnor trishaoconnor self-requested a review November 20, 2023 18:08
@sydb sydb added this to the Release 7.57.0 milestone Nov 20, 2023
@trishaoconnor trishaoconnor removed their request for review November 20, 2023 18:09
@trishaoconnor trishaoconnor merged commit 8386be2 into TEIC:dev Nov 20, 2023
0 of 2 checks passed
@jbampton jbampton deleted the fix-spelling branch November 21, 2023 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydb sydb sydb approved these changes

Assignees

@trishaoconnor trishaoconnor

Labels
None yet
Projects
None yet
Milestone
Release 7.57.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jbampton @martindholmes @sydb @trishaoconnor