Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add <taxonomy> and <category> to att.datcat (issue #2419 ) #2422

Merged
merged 12 commits into from
Oct 26, 2023

Conversation

bansp
Copy link
Member

@bansp bansp commented Apr 24, 2023

This PR extends the description in the att.datcat spec and adds taxonomy and category elements to that class.
The description adds to the the linguistic picture but also shows the usage of the attributes elsewhere, in usage labels in dictionaries (the usg element).

Some references to the example dictionary are missing in the initial version, pending beautification.

The result can be seen at https://jenkins-paderborn.tei-c.org/view/LingSIG/job/TEIP5-LingSIG-tests/lastSuccessfulBuild/artifact/P5/release/doc/tei-p5-doc/en/html/ref-att.datcat.html

@bansp bansp linked an issue Apr 24, 2023 that may be closed by this pull request
@@ -219,6 +270,48 @@ $Id$
its values, which are used as direct references to data categories; hence the use of
<att>datcat</att> in the <gi>symbol</gi> element.</p>
</exemplum>
<exemplum xml:lang="en">
<p>The <ident type="class">att.datcat</ident> attributes can be used for any sort of taxonomies. The example below illustrates their usefulness for describing usage domain labels in dictionaries on the example of Morais (REFERENCE). </p>
Copy link
Member

@ebeshero ebeshero Sep 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bansp Council is reviewing this at Paderborn, and noticed that we're missing a reference here--presumably something to add to BIB, too. Can you add these?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ebeshero . I left that for the Lex-0 colleagues to add, and with at least @ttasovac and (I hope) @laurentromary present in Paderborn, this is going to be a quick job.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ebeshero Please kindly review the most recent edit. I've made it online, so without any checks beyond those offered by Github. I hope hi/@rend="it" was the right markup to use.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@ebeshero ebeshero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bansp Can you change that <hi rend="it"> to <title level='m'>? (Or is there a reason you didn't use it?)

<exemplum xml:lang="en">
<p>The <ident type="class">att.datcat</ident> attributes can be used for any sort of taxonomies.
The example below illustrates their usefulness for describing usage domain labels in
dictionaries on the example of the <hi rend="it">Diccionario da Lingua Portugueza</hi> by
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bansp This <hi rend='it>should probably be<title level='m'>`, yes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By all means. Thanks, Elisa and Hugh, for having a look at it. Gonna change the markup right away,

Copy link
Member

@ebeshero ebeshero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bansp Reviewing the whole package now--everything looks good to me! I think this is ready to merge.

@bansp
Copy link
Member Author

bansp commented Oct 26, 2023

Weeee, thanks for the nice news, Elisa! :-)

@ebeshero
Copy link
Member

ebeshero commented Oct 26, 2023

@bansp I'm sorry it took us so long! But perhaps at last the epic day of merging this branch has finally arrived! :-)

@HelenaSabel HelenaSabel merged commit 4a04833 into TEIC:dev Oct 26, 2023
1 check passed
@bansp
Copy link
Member Author

bansp commented Oct 26, 2023

Many thanks to everyone involved. It's a nice step forward :-)

@ebeshero ebeshero added this to the Guidelines 4.7.0 milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add <taxonomy> and <category> to att.datcat
4 participants