-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add <taxonomy>
and <category>
to att.datcat (issue #2419 )
#2422
Conversation
P5/Source/Specs/att.datcat.xml
Outdated
@@ -219,6 +270,48 @@ $Id$ | |||
its values, which are used as direct references to data categories; hence the use of | |||
<att>datcat</att> in the <gi>symbol</gi> element.</p> | |||
</exemplum> | |||
<exemplum xml:lang="en"> | |||
<p>The <ident type="class">att.datcat</ident> attributes can be used for any sort of taxonomies. The example below illustrates their usefulness for describing usage domain labels in dictionaries on the example of Morais (REFERENCE). </p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bansp Council is reviewing this at Paderborn, and noticed that we're missing a reference here--presumably something to add to BIB, too. Can you add these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @ebeshero . I left that for the Lex-0 colleagues to add, and with at least @ttasovac and (I hope) @laurentromary present in Paderborn, this is going to be a quick job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've backported the edit to the LingSIG repo and the result is going to be soon shown under
https://jenkins-paderborn.tei-c.org/view/LingSIG/job/TEIP5-LingSIG-tests/lastSuccessfulBuild/artifact/P5/release/doc/tei-p5-doc/en/html/ref-att.datcat.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bansp Can you change that <hi rend="it">
to <title level='m'>
? (Or is there a reason you didn't use it?)
P5/Source/Specs/att.datcat.xml
Outdated
<exemplum xml:lang="en"> | ||
<p>The <ident type="class">att.datcat</ident> attributes can be used for any sort of taxonomies. | ||
The example below illustrates their usefulness for describing usage domain labels in | ||
dictionaries on the example of the <hi rend="it">Diccionario da Lingua Portugueza</hi> by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bansp This <hi rend='it
>should probably be
<title level='m'>`, yes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By all means. Thanks, Elisa and Hugh, for having a look at it. Gonna change the markup right away,
use title rather than hi
Thanks, Peter Stadler! Fixing a compatibility failure to allow a build to pass for issue TEIC#2419
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bansp Reviewing the whole package now--everything looks good to me! I think this is ready to merge.
Weeee, thanks for the nice news, Elisa! :-) |
@bansp I'm sorry it took us so long! But perhaps at last the epic day of merging this branch has finally arrived! :-) |
Many thanks to everyone involved. It's a nice step forward :-) |
This PR extends the description in the att.datcat spec and adds
taxonomy
andcategory
elements to that class.The description adds to the the linguistic picture but also shows the usage of the attributes elsewhere, in usage labels in dictionaries (the
usg
element).Some references to the example dictionary are missing in the initial version, pending beautification.
The result can be seen at https://jenkins-paderborn.tei-c.org/view/LingSIG/job/TEIP5-LingSIG-tests/lastSuccessfulBuild/artifact/P5/release/doc/tei-p5-doc/en/html/ref-att.datcat.html