remove @scheme requirement when <constraintSpec> is mode=change or delete
#2453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Made scheme= of constraintSpec optional (per closed schema) * Made scheme= of constraintSpec required iff mode=add (default) or mode=replace * Moved declarations of Schematron namespaces from constraintSpec to TEI in order to make above work * Added a case in detest.odd to test new constraints
|
Note that the tests here are still failing on “/lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found”, so probably nothing to do with the changes. This branch passed all the tests that my Mac laptop runs, but I do not have a docker container on this machine. |
joeytakeda
reviewed
Nov 3, 2023
| @@ -1,11 +1,11 @@ | |||
| Buildfile: /TEI/P5/Test/antruntest.xml | |||
| Buildfile: /Users/syd/Documents/TEI_gitHub/P5/Test/antruntest.xml | |||
There was a problem hiding this comment.
I presume that the expected results here should not be user specific -- should these all be /TEI/ ?
sydb
changed the title
@scheme requirement when <constraintSpec> is mode=add or replace@scheme requirement when <constraintSpec> is mode=change or delete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@schemeof<constraintSpec>optional (per closed schema)@schemeof<constraintSpec>required iff mode=add (default) or mode=replace (per open schema)Note for reviewing: I did this work on a machine that does not have spell-checking installed for Emacs (yet). So probably worth reading the prose changes carefully.