Add eventName and update event #2483

joeytakeda · 2023-10-06T23:22:34Z

I think, after lots of work and discussion, eventName (and the new and improved event) are near ready for showtime 🎉 .

This PR should close #2382 and #2466 (with thanks to @djakacki , @skurzinz, @sydb, and @JanelleJenstad !)

You can view the proposed version of the Guidelines here: https://www.sfu.ca/~takeda/tei-guidelines/issue_2382_eventName/html/

Major changes here include:

The addition of <eventName>
Significant changes to <event>s content model and description
Changes to "13 Names, Dates, People, and Places"

For reviewers, if you can, please check the descs in event and eventName as some of will be outdated (or non-existent, in the case of eventName) (I'm also not sure if everyone assigned needs to review, but I thought that more eyes wouldn't hurt)

#2382 - include an example - in addition there are a few comments on where the guidelines may need further clarification: As a pointer I included the string > "XXX #2382 `event` and `eventName` XXX"

- move "orphan" description from place section to event section - refer to new general section from person-event and place-event parts - include a few sentences that hopefully fit the bill for a generic event description

relates to #2427 (comment)

merge upstream changes

Mostly tweaking content models and examples so that examples are valid. The lone exception is “Platter”, Filip Fabricius’ additional name in the tagdoc for the 'event' element, which is still invalid.

@sydb

thx @sydb for pointing this out in #2427 (comment)

- make one nested list - ptr instead of ref for internal Guidelines references

clarification in example of Paris terrorist attacks

@skurzinz

* Updating example and German gloss (thanks, @skurzinz!)

sydb

Technical portions look very good. Overall prose & examples look good, too, but a few suggestions follow.

P5/Source/Guidelines/en/ND-NamesDates.xml

P5/Source/Specs/eventName.xml

sabineseifert · 2023-10-16T10:39:00Z

P5/Source/Guidelines/en/ND-NamesDates.xml

+      <p>The <gi>eventName</gi> element is provided in parallel to other naming mechanisms, and especially for <soCalled>canonical</soCalled>
+      names that are used in texts to mention specific named events.
+        <egXML xmlns="http://www.tei-c.org/ns/Examples">
+          <p>On <date when="1719-03-19">Monday</date>, <rs type="person">she</rs> was writing about the 


Does that general encoding with just the value "person" make sense? At least, the date and the two events in this example are encoded in a more detailed way, i.e. reference to something specific.

Yes, agreed that the use of <rs> here may be a bit distracting, especially since it's not providing additional info...

Note that this is only instance of the use of <rs> tagging just a pronoun (i.e. the rest are slightly more specific, including things like "his lady" or "City of Brotherly Love") [NB: this example is duplicated in the elementSpec for eventName, so we'll want to change that there too if we change it here]

P5/Source/Guidelines/en/ND-NamesDates.xml

sabineseifert · 2023-10-16T10:43:05Z

P5/Source/Guidelines/en/ND-NamesDates.xml

+      </p>
+      <p>The <gi>eventName</gi> element is used to mark up real and fictitious event names as they appear in the edited text.
+        As explained with regard to the <gi>event</gi> element (see <ptr target="#NDEVNT"/>), 
+        the use of these elements does not define what might be an important event for a particular edition. Temporal extent, 


same as my comment for line 751: it need not be an edition. Better phrase perhaps "project"?

We have similar phrasing in #NDEVNT

These guidelines do not prescribe what encoders count as events, nor their granularity, nesting, or amount of other information to record in relation to each event.

And now that I read the rest of this, I think the sentence is a bit broken:

Temporal extent, granularity of events (and hence of their names) are up to the encoders.

IMO, we should delete these sentences and just merge this with the following paragraph:

<p>The <gi>eventName</gi> element is used to mark up real and fictional event names as they appear in the source. <gi>eventName</gi> may be used in conjunction with well-defined (e.g. historical) events that are established in a particular ...

P5/Source/Guidelines/en/ND-NamesDates.xml

sabineseifert · 2023-10-16T13:01:21Z

P5/Source/Guidelines/en/ND-NamesDates.xml

+      <egXML xmlns="http://www.tei-c.org/ns/Examples" source="#NDGEOGste-Falls">
+        <standOff>
+          <!-- ========= events ========= -->
+          <listEvent>


This is a long list of events with, therefore, long lists of related places and persons. Could/Should that be shortened perhaps?
Edit: I see, this is not a new example but it is already in the Guidelines. But still maybe worth shortening for easier reading?

Again, I think we can work on improving the examples in time for the release after this one. When Council discussed this in Paderborn we wanted to prioritize releasing the new content model and encoding, but work on improving the examples later.

P5/Source/Guidelines/en/ND-NamesDates.xml

P5/Source/Specs/event.xml

P5/Source/Specs/eventName.xml

sabineseifert · 2023-10-16T13:37:21Z

(I suggested some changes but then hit the button just for "approve" not for requesting changes.)

P5/Source/Guidelines/en/ND-NamesDates.xml

@sydb

With thanks to @sydb, @sabineseifert, and @ebeshero. Still more to go, but this should get most of the easy stuff

…by hand

P5/Source/Specs/event.xml

@sabineseifert

With thanks to @sabineseifert!

sydb

I will not say there is nothing wrong with this PR, but I will say I did not notice anything that would prevent release.

skurzinz · 2023-11-05T09:13:00Z

Many thanks @sabineseifert @joeytakeda @sydb for revising this again. Sorry for being inresponsive, was traveling yet did check occasionally: every change was necessary and appropriate. Many thanks.

ebeshero · 2023-11-07T14:39:04Z

P5/Source/Guidelines/en/ND-NamesDates.xml

+            </event>
+            <event when="1778" ref="http://avalon.law.yale.edu/18th_century/del1778.asp">
+              <label>Treaty of Fort Pitt</label>
+              <desc>Also known as the <name type="event">Treaty with the Delawares</name>, this was the first written treaty


Okay--I'm reviewing our discussion of this from Paderborn, and I remember Council found this particular example to be problematic.
We wanted to go through and revise the examples (this one in particular) to change <label> to <eventName>.

At Paderborn we recommended that <label> be applied to a change of state, while <eventName> be used for an event with a name. (Admittedly changes in state like a coronation would probably be given a name, so this may be a little ambiguous.) But in this example, at this particular point, this is the only time we see <name type="event"> while everything else is encoded with <label>. I think we did intend to change this example to match the new <eventName> or at least to make the encoding more consistent throughout (as in, apply <label> to "Treaty with the Delawares" and elevate it to the same position as "Treaty of Fort Pitt". @joeytakeda

I see that we also recommended simply merging the PR to make <eventName> available at last, and open a ticket to improve the examples later, so I'm not going to raise this as an objection--just noting it as something we need to revisit! As soon as we merge this PR, we should open a new ticket. (I'll probably just do that.) @joeytakeda

ebeshero

@joeytakeda and all: I'm in favor of merging the PR because the content model and new examples on the <eventName> specs are important new contributions to the Guidelines. However, I think as soon as we merge this, we need a new ticket (for a later release cycle) to work on updating and improving the Guidelines examples of <event> in the ND chapter to provide some consistent guidance/examples on when to use <label> and when to use <eventName>.

ebeshero · 2023-11-07T14:49:54Z

And, as I'm assigned, I'll merge it in now!

skurzinz and others added 30 commits May 2, 2023 15:53

update tei:event description

acc29ba

update tei:event model and provide example

adfbf43

provide tagdoc for tei:eventName

24c3606

allow listPerson and listEvent as children of listEvent

b58f593

add eventName into chapter 13 ND

c247fb8

#2382 - include an example - in addition there are a few comments on where the guidelines may need further clarification: As a pointer I included the string > "XXX #2382 `event` and `eventName` XXX"

fix cardinalities for (list)?event child elements

fbd490b

new div2 on events

876e1eb

- move "orphan" description from place section to event section - refer to new general section from person-event and place-event parts - include a few sentences that hopefully fit the bill for a generic event description

move nested event example to new event section

eb6c737

correct a typo

679744a

check cardinalities with @ChristianeFritze

21204de

add @type to event example in specs

9e2a984

improve example of indirect event reference

b6bd949

improve description of event in ND

45e95ab

include eventName spec in ND as suggested by @sydb

62b1b9a

remove listPerson|Place from listEvent again

8680301

relates to #2427 (comment)

address first of @sydb’s comment in #2427 (dup xi:include)

14376d5

swap out eventName example

7d8a834

eventName made member of att.personal

24f6e72

update versionDate of event; add german desc

8ddc809

add objectLike elements to possible children of event

ea40022

Removed ambiguities from content models

6c68379

Merge pull request #1 from TEIC/dev

4d39c1c

merge upstream changes

add a TEI2019 Graz example for typed eventName

3e69268

Fix invalidities:

c8e723c

Mostly tweaking content models and examples so that examples are valid. The lone exception is “Platter”, Filip Fabricius’ additional name in the tagdoc for the 'event' element, which is still invalid.

fix remaining problem (yank Platter addName)

d52818c

thx @sydb for pointing this out in #2427 (comment)

formatting

f2fbf36

- make one nested list - ptr instead of ref for internal Guidelines references

remove comments with references to the #2382 issuex

d0fa3c2

add clarifying comment on legislation understood as event

e2c432f

alternative <listPlace> and/or @where for locating events

1f1aaa4

clarification in example of Paris terrorist attacks

add de_AT nested listEvent example to #2427

395ad63

Continued work on event and eventName (#2382, #2466)

1fcf6f7

* Updating example and German gloss (thanks, @skurzinz!)

joeytakeda requested review from sydb, raffazizzi, ebeshero, sabineseifert and HelenaSabel October 6, 2023 23:22

sydb requested changes Oct 8, 2023

View reviewed changes

sabineseifert reviewed Oct 16, 2023

View reviewed changes

sabineseifert approved these changes Oct 16, 2023

View reviewed changes

sabineseifert reviewed Oct 16, 2023

View reviewed changes

P5/Source/Guidelines/en/ND-NamesDates.xml Show resolved Hide resolved

joeytakeda and others added 4 commits October 16, 2023 15:16

Small editorial tweaks for PR #2483

e12c857

With thanks to @sydb, @sabineseifert, and @ebeshero. Still more to go, but this should get most of the easy stuff

Merge branch 'dev' into issue_2382_eventName

ecdc71a

auto-merge latest from dev, except event.xml, which had to be merged …

fe62239

…by hand

Oops; added missing namespace decl

47d93db

sabineseifert reviewed Oct 26, 2023

View reviewed changes

P5/Source/Specs/event.xml Outdated Show resolved Hide resolved

joeytakeda and others added 4 commits November 2, 2023 18:20

More updates to prose

e699800

With thanks to @sabineseifert!

Fixes to event

bda7de7

Merge branch 'dev' into issue_2382_eventName

eec20e5

Re-work prose of eventName section

91bb308

sydb approved these changes Nov 4, 2023

View reviewed changes

sydb removed the request for review from ebeshero November 4, 2023 02:19

sydb assigned ebeshero Nov 4, 2023

sydb added this to the Guidelines 4.7.0 milestone Nov 4, 2023

ebeshero reviewed Nov 7, 2023

View reviewed changes

ebeshero approved these changes Nov 7, 2023

View reviewed changes

ebeshero merged commit 023167f into dev Nov 7, 2023
2 checks passed

ebeshero added this to the Guideline 4.7.0 milestone Nov 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add eventName and update event #2483

Add eventName and update event #2483

joeytakeda commented Oct 6, 2023

sydb left a comment

sabineseifert Oct 16, 2023

joeytakeda Nov 3, 2023

sabineseifert Oct 16, 2023

joeytakeda Nov 3, 2023

sabineseifert Oct 16, 2023

ebeshero Nov 7, 2023

sabineseifert commented Oct 16, 2023

sydb left a comment

skurzinz commented Nov 5, 2023

ebeshero Nov 7, 2023

ebeshero Nov 7, 2023

ebeshero left a comment

ebeshero commented Nov 7, 2023

Add eventName and update event #2483

Add eventName and update event #2483

Conversation

joeytakeda commented Oct 6, 2023

sydb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sabineseifert commented Oct 16, 2023

sydb left a comment

Choose a reason for hiding this comment

skurzinz commented Nov 5, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ebeshero left a comment

Choose a reason for hiding this comment

ebeshero commented Nov 7, 2023