Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README encoding improvements ala #2070 #2494

Merged
merged 4 commits into from
Nov 9, 2023
Merged

README encoding improvements ala #2070 #2494

merged 4 commits into from
Nov 9, 2023

Conversation

sydb
Copy link
Member

@sydb sydb commented Oct 23, 2023

Per #2070 step 2, change encoding of class names from <ident> (with or without type="class") to <name type="class">; and, in the case of 2.2.0 element names and class names from plain text to <gi> and <name type="class">, respectively. I did not fix any of the other individual problems noted in #2070 note [2], yet, but might get to it before this is merged. (None of those changes have to be done in conjunction with the changes here, but we should do them now lest we forget.)

WARNING
This PR cannot be considered in isolation, it must be combined with the corresponding PR in the Stylesheets repo.

@sydb
Copy link
Member Author

sydb commented Oct 23, 2023

In 29935ed I fixed most of the little things listed in note [2] on the ticket, #2070. I do not claim all errors are fixed, but I do claim that this branch is now significantly better than dev.

@ebeshero ebeshero self-assigned this Nov 9, 2023
@sydb sydb merged commit 8ddff14 into dev Nov 9, 2023
3 checks passed
@ebeshero ebeshero added this to the Guideline 4.7.0 milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants