Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

address #1981 with SchXslt (aka mausatron) instead of skeleton #2509

Open
wants to merge 18 commits into
base: dev
Choose a base branch
from
Open

address #1981 with SchXslt (aka mausatron) instead of skeleton #2509

wants to merge 18 commits into from

Conversation

sydb
Copy link
Member

@sydb sydb commented Nov 27, 2023

I will say more shortly, but the main point now is that this PR updates our build process to use @dmj’s SchXslt (which I call “mausatron”) rather than the original skeleton implementation. This has quite a few minor advantages, but mainly allows users (including us) to

  1. use abstract patterns; and
  2. use an attribute as a context node.

Reviewers — the lastest merge from dev into this branch (issue1981bis) required that the various Test/expected_results/detest*log files be hand-merged. Thus it is appropriate to take a pretty careful look at these.

raffazizzi and others added 12 commits April 13, 2022 19:06
@raffazizzi @github-actions
Re-generated spec lists.
69f0c62
@sydb
Switch Schematron processing from skeleton implementation to mausatro…
1b444e9 
…n (aka schxslt)
@sydb
Oops; forgot to actually ADD the mausatron (aka schxslt) processor. T…
97ff734 
…his is https://github.com/schxslt/schxslt/releases/tag/v1.9.5.
@sydb
Last step (that I know of) in skeleton→mausatron process.
188235d
@sydb
Change how SVRL is logged and compared.
9ec4648
@sydb
Ooops; forgot to change code that removed filepath from detest1.log
3132022
@sydb
Merge in latest from dev, resolving really complex conflicts because …
1b2ce70 
…I was an idiot and did not merge *before* I started on move to mausatron (aka schxslt).
@sydb @github-actions
Re-generated spec lists.
405b434
@sydb
Add abstract pattern for att.declarable, and concrete instantiations …
2d82edf 
…of it in members of att.declarable.
@sydb
Add abstract pattern for att.declarable, and concrete instantiations …
6044db6 
…of it in members of att.declarable.
@sydb
Grab newest from dev
98154c4
@sydb
Merge in the enormous progress made in dev branch into this one, whic…
d2f20d1 
…h required manually merging 4 files (P5/Test/detest.xml, P5/Test/expected-results/detest_odd_schematron.log, P5/Test/expected-results/detest_xml_relaxng.log, and P5/Test/expected-results/detest_xml_schematron.log) and updating the Makefile
@sydb sydb added this to the Guidelines 4.8.0 milestone Nov 27, 2023
@sydb
Copy link
Member Author

sydb commented Feb 2, 2024

I just merged the current dev branch into this branch, Guidelines still build (include make test) without error.
I am kinda hoping this could get pulled in before our Council meeting on Fri 09 Feb 24. Pipe dream or realistic?

@joeytakeda
Copy link
Contributor

There seems to be an error with (I believe) the NVDL part of the build (note that this is not causing the build to fail, but is producing error messages—you can see it in the Actions build as well as when run locally):

BUILD: Check validity with nvdl, first examples with feasible validity, and then the valid ones
./run-onvdl p5.nvdl p5.xml
Schema implementation error: This schema has abstract patterns, yet they are supposed to be preprocessed out already
             
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
./run-onvdl p5valid.nvdl v.xml
Schema implementation error: This schema has abstract patterns, yet they are supposed to be preprocessed out already
             
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam
Error: unrecognized element in ISO Schematron namespace: check spelling
			and capitalizationparam

raffazizzi and others added 3 commits April 12, 2024 19:57
@raffazizzi
Merge branch 'dev' into issue1981bis
7d808ad
@sydb
Various fixes to detest:
0104604 
 * Compare SVRL output of Schematron validation of ODD file.
 * Deleted redundant "testingSpan" section of XML file (which I think I accidentally introduced on a previous attempt to merge in dev).
 * Updated expected-results/ accordingly.
@sydb
Bug fix in Makefile:
028b2ab 
In addition to a timestamp, the SVRL files contain filepaths and auto-generated namespace prefixes,
so they cannot be directly compared. Instead, extract only the svrl:text elements and compare ’em.
@sabineseifert
Copy link
Contributor

Full Council discussion on April 13 at VF2F:

European subgroup was getting the same errors.
Several options discussed:

  1. find someone to fix nvdl validation
  1. Stop using nvdl entirely:
  • remove the nvdl files (because they just don't work)
  • Or stop using the nvdl files in build process
  1. Continue using nvdl with line 105 commented out, but then need to fix the produced NVDL documents

Decision: find someone to fix nvdl validation
Get update on oNVDL at Balisage. If there has been no further work on oNVDL then we could proceed with getting rid of it since no-one is using it.

@ebeshero ebeshero mentioned this pull request Jul 1, 2024
Open
@trishaoconnor trishaoconnor added Status: Needs Discussion Status: Pending pending action described in a comment, to return to discussion before further action will be taken and removed Status: Needs Discussion labels Nov 27, 2024
@sydb
Copy link
Member Author

sydb commented Nov 27, 2024

Get update on oNVDL at Balisage. If there has been no further work on oNVDL then we could proceed with getting rid of it since no-one is using it.

I was unsuccessful in finding out about oNVDL support at Balisage. Next step is to ask on XML Slack, or no repo, or direct to author(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hcayless hcayless Awaiting requested review from hcayless

@martindholmes martindholmes Awaiting requested review from martindholmes

Assignees

@raffazizzi raffazizzi

Labels
CouncilResponsibility Priority: High Status: Pending pending action described in a comment, to return to discussion before further action will be taken TEI: Build Process TEI: Guidelines & Documentation TEI: Schematron
Projects
None yet
Milestone
Guidelines 4.9.0
Development

Successfully merging this pull request may close these issues.
6 participants
@sydb @joeytakeda @sabineseifert @raffazizzi @ebeshero @trishaoconnor